From patchwork Sun Jul 9 19:42:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 9832003 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4D90760317 for ; Sun, 9 Jul 2017 19:42:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D75B27A98 for ; Sun, 9 Jul 2017 19:42:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B2A2280B0; Sun, 9 Jul 2017 19:42:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C18A327A98 for ; Sun, 9 Jul 2017 19:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbdGITmn (ORCPT ); Sun, 9 Jul 2017 15:42:43 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36635 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbdGITmj (ORCPT ); Sun, 9 Jul 2017 15:42:39 -0400 Received: by mail-wr0-f194.google.com with SMTP id 77so20375322wrb.3 for ; Sun, 09 Jul 2017 12:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gmbTZk2a9tEehv7ZqmW60QK+1VK+gDgvZxxXCBgMpBM=; b=SJ0OXc/MCXV7vcT1RhAE0LM6NZaGa2DKQtZf0WJIAiiaNZAEQQg+CJFcPEUxlZf9qN CaNrQ8Pbw7ucUYT+jE8wvitkeeYJrO+lqVUQfwoE/zHcL+nq+N9vPwwp4hffjPkMa1Yl PhOkw/ff1M04gEZXbPQFRGO2eRrpUgO1//6WBN6vOQsJKYvuyOm+bDOoXzg64FBBusX/ yRiukizrlqU8gFV4AIxb6Dgbe1ULUWmyMFtHWPifn6As7j8w07DFib3BI0FaMIhEmN8h 9RlUQ+YfzTD3UtCr5Ji+s0IntN9fvbc+DV7RqGDkT2mn4es3X2ZsmG2bpZiKd2gOXPum doAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gmbTZk2a9tEehv7ZqmW60QK+1VK+gDgvZxxXCBgMpBM=; b=AerO7a1qQiDP/ouxzjGfXdXqhUjAT+wIezhrIk7Ts/QmUXbWKYRu01nFMSKbIDLJ3w IJxqVuKKVRiDQfPzRgpgsxSPBtTDSZhqYQFRLCrUepoHH0tyYtovNh8VubW3oHR5uKuv i9ItI4tSWNjP5R5U67Q5RP7nmBJVOxQAbiyLu3NJoH1y1P+ZTssuCGPdx81BuoRdQ9bh XtLsXc1r27QUNQryDHbsoPAFgRyfz6M+l/begvKobL1NyO4X1SH5OrWB1JK63O/qbdqJ J7EkNpQtuF2Pq6UCxryjOYJe9cj1BZI+LEyM5K4kp6EvXBXvAEu3lc9Mm5PwSZCCpaQ8 IjbQ== X-Gm-Message-State: AIVw112f42g65Z98oj+7fHvxgRbA4YjZjb91ZCQ0R6IK8rgf7D+ZJ1My fZAoqmgM7qbzAd1b X-Received: by 10.28.150.139 with SMTP id y133mr5487100wmd.61.1499629357470; Sun, 09 Jul 2017 12:42:37 -0700 (PDT) Received: from dvbdev.wuest.de (ip-37-24-178-151.hsi14.unitymediagroup.de. [37.24.178.151]) by smtp.gmail.com with ESMTPSA id f45sm18129346wrf.2.2017.07.09.12.42.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 09 Jul 2017 12:42:37 -0700 (PDT) From: Daniel Scheller To: linux-media@vger.kernel.org, mchehab@kernel.org, mchehab@s-opensource.com Cc: jasmin@anw.at, d_spingler@gmx.de, rjkm@metzlerbros.de Subject: [PATCH 13/14] [media] ddbridge: Kconfig option to control the MSI modparam default Date: Sun, 9 Jul 2017 21:42:20 +0200 Message-Id: <20170709194221.10255-14-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170709194221.10255-1-d.scheller.oss@gmail.com> References: <20170709194221.10255-1-d.scheller.oss@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller It is known that MSI interrupts - while working quite well so far - can still cause issues on some hardware platforms (causing I2C timeouts due to unhandled interrupts). The msi variable/option is set to 1 by default. So, add a Kconfig option prefixed with "EXPERIMENTAL" that will control the default value of that modparam, defaulting to off for a better user experience and (guaranteed) stable operation "per default". Cc: Ralph Metzler Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/Kconfig | 15 +++++++++++++++ drivers/media/pci/ddbridge/ddbridge-main.c | 11 +++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/ddbridge/Kconfig b/drivers/media/pci/ddbridge/Kconfig index c79a58fa5fc3..1330b2ecc72a 100644 --- a/drivers/media/pci/ddbridge/Kconfig +++ b/drivers/media/pci/ddbridge/Kconfig @@ -26,3 +26,18 @@ config DVB_DDBRIDGE - CineS2 V7/V7A and DuoFlex S2 V4 (ST STV0910-based) Say Y if you own such a card and want to use it. + +config DVB_DDBRIDGE_MSIENABLE + bool "Enable Message Signaled Interrupts (MSI) per default (EXPERIMENTAL)" + depends on DVB_DDBRIDGE + depends on PCI_MSI + default n + ---help--- + Use PCI MSI (Message Signaled Interrupts) per default. Enabling this + might lead to I2C errors originating from the bridge in conjunction + with certain SATA controllers, requiring a reload of the ddbridge + module. MSI can still be disabled by passing msi=0 as option, as + this will just change the msi option default value. + + If you're unsure, concerned about stability and don't want to pass + module options in case of troubles, say N. diff --git a/drivers/media/pci/ddbridge/ddbridge-main.c b/drivers/media/pci/ddbridge/ddbridge-main.c index fa4f663c5acb..83643bc21d09 100644 --- a/drivers/media/pci/ddbridge/ddbridge-main.c +++ b/drivers/media/pci/ddbridge/ddbridge-main.c @@ -46,10 +46,17 @@ MODULE_PARM_DESC(adapter_alloc, "0-one adapter per io, 1-one per tab with io, 2-one per tab, 3-one for all"); #ifdef CONFIG_PCI_MSI +#ifdef CONFIG_DVB_DDBRIDGE_MSIENABLE int msi = 1; +#else +int msi; +#endif module_param(msi, int, 0444); -MODULE_PARM_DESC(msi, - " Control MSI interrupts: 0-disable, 1-enable (default)"); +#ifdef CONFIG_DVB_DDBRIDGE_MSIENABLE +MODULE_PARM_DESC(msi, "Control MSI interrupts: 0-disable, 1-enable (default)"); +#else +MODULE_PARM_DESC(msi, "Control MSI interrupts: 0-disable (default), 1-enable"); +#endif #endif int ci_bitrate = 70000;