From patchwork Wed Jul 12 20:31:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 9837359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B5922602A0 for ; Wed, 12 Jul 2017 20:31:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A914E28658 for ; Wed, 12 Jul 2017 20:31:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D61428682; Wed, 12 Jul 2017 20:31:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A7CF28658 for ; Wed, 12 Jul 2017 20:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753216AbdGLUbJ (ORCPT ); Wed, 12 Jul 2017 16:31:09 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33472 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbdGLUbI (ORCPT ); Wed, 12 Jul 2017 16:31:08 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 482708239A; Wed, 12 Jul 2017 22:31:06 +0200 (CEST) Date: Wed, 12 Jul 2017 22:31:05 +0200 From: Pavel Machek To: Sakari Ailus Cc: Laurent Pinchart , mchehab@kernel.org, kernel list , ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org Subject: omap3isp: is capture mode working? what hardware? was Re: v4l2-fwnode: status, plans for merge, any branch to merge against? Message-ID: <20170712203105.GA26734@amd> References: <20170302123848.GA28230@amd> <20170304130318.GU3220@valkosipuli.retiisi.org.uk> <20170306072323.GA23509@amd> <20170310225418.GJ3220@valkosipuli.retiisi.org.uk> <20170613122240.GA2803@amd> <20170613124748.GD12407@valkosipuli.retiisi.org.uk> <20170613210900.GA31456@amd> <20170614110634.GP12407@valkosipuli.retiisi.org.uk> <20170704150819.GA10703@localhost> <20170705093248.hndchnamibhqczfr@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170705093248.hndchnamibhqczfr@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! > What I've done is just rebased the ccp2 branch. In other words, the patches > in that branch are no more ready than they were. > > To get these merged we should ideally > > 1) Make sure there will be no regressions, I grepped dts trees a bit... where is omap3isp currently used? Anything besides N9 and N950? Does the capture mode currently work for you? Because as far as I can tell, formatter is disabled, so video is in wrong format for the userspace. So something like patch below is needed; (of course after adjusting the comment etc.) Thanks, Pavel commit eb81524b8b44bbff2518b272cb3de304157bd3ba Author: Pavel Date: Mon Feb 13 21:26:51 2017 +0100 omap3isp: fix VP2SDR bit so capture (not preview) works This is neccessary for capture (not preview) to work properly on N900. Why is unknown. diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 7207558..2fb755f 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -1186,7 +1186,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) /* Use the raw, unprocessed data when writing to memory. The H3A and * histogram modules are still fed with lens shading corrected data. */ - syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; +// syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; + syn_mode |= ISPCCDC_SYN_MODE_VP2SDR; if (ccdc->output & CCDC_OUTPUT_MEMORY) syn_mode |= ISPCCDC_SYN_MODE_WEN;