From patchwork Sat Jul 29 11:28:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 9869913 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5B6E560382 for ; Sat, 29 Jul 2017 11:30:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 564092889B for ; Sat, 29 Jul 2017 11:30:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B7272889C; Sat, 29 Jul 2017 11:30:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DB3F288D4 for ; Sat, 29 Jul 2017 11:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753760AbdG2L3N (ORCPT ); Sat, 29 Jul 2017 07:29:13 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34800 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753730AbdG2L3E (ORCPT ); Sat, 29 Jul 2017 07:29:04 -0400 Received: by mail-wm0-f66.google.com with SMTP id x64so5864314wmg.1 for ; Sat, 29 Jul 2017 04:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c645tfRQ/I8P6OL1u5kUkGt3GBePIBkw26O8Ek1W+Y0=; b=WhwA9Zcld1UONfgtOYJa5lRsvWj6A14YvbNJmpjXtDwSiE4zcrEre71ebSziuDdjYU etcObxoigxwoNvoZKS+HjJr7k8d4kp0HApPAJN95NwOUjC4VsQwsgl4TBEMLtasESRWR F7tMCV2d0WHzGweaGrwfgVu0blwBp2qOpEpZlE9xw0Sd7DcgMzT0uab6IwnhUO7P/Ojq r82CI+RJk0exbhlXPCiiNuUDNaU2kGSNeW/fPSxtvLmLQU9ZoOsPDAEvYRuDGMbAA54r V5nsoXIl46UwbGdcdtOjOgevFfHhT9E2g6xJDjn1B1fRVyTEweoY2oUlOajbdPC9s8Fa ysBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c645tfRQ/I8P6OL1u5kUkGt3GBePIBkw26O8Ek1W+Y0=; b=lpVpNFhBcdKAD6pOmiXiTT4UiC148R47cTQOIukL09lmoe6tuLfCaVEqBx3RYuZ6B+ 3JfStc445enovghuimnlkEnQSBNnsVHHoB9UlxuttmRECmCwTW/SmsYueFSGULslaQp7 EnhNNXePUteUK708cyv1i9DHzIY4AyB6QbQM4LvliD/kGCPdrJ0Q9QVyPJGyXVfdUptu 0ReXl7QM8VjNKCUw/EYOhW6OM7FzAr3gwcA3UJ4g9pn1jeDUpcrPAyRRWztKhQgZWNRF wjejfQVjIRP6kHPcSQMne4kGBOOEVjO8ntvyeSDJUEJfypFNFNVpSHWb62hT7YPPSGeQ oYmw== X-Gm-Message-State: AIVw110J7TG1UkwKtAoGwriveo4zoKwevOTqu0upSaCUThWKw+Jtbj26 Af5h/HLXbpiqmu7g X-Received: by 10.28.61.4 with SMTP id k4mr7104129wma.146.1501327743106; Sat, 29 Jul 2017 04:29:03 -0700 (PDT) Received: from dvbdev.wuest.de (ip-84-118-193-88.unity-media.net. [84.118.193.88]) by smtp.gmail.com with ESMTPSA id o68sm6220054wmi.21.2017.07.29.04.29.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 29 Jul 2017 04:29:02 -0700 (PDT) From: Daniel Scheller To: linux-media@vger.kernel.org, mchehab@kernel.org, mchehab@s-opensource.com Cc: r.scobie@clear.net.nz, jasmin@anw.at, d_spingler@freenet.de, Manfred.Knick@t-online.de, rjkm@metzlerbros.de Subject: [PATCH v2 11/14] [media] ddbridge: fix impossible condition warning Date: Sat, 29 Jul 2017 13:28:45 +0200 Message-Id: <20170729112848.707-12-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170729112848.707-1-d.scheller.oss@gmail.com> References: <20170729112848.707-1-d.scheller.oss@gmail.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller Smatch and gcc complained: drivers/media/pci/ddbridge/ddbridge-core.c:3491 bpsnr_show() warn: impossible condition '(snr[0] == 255) => ((-128)-127 == 255)' drivers/media/pci/ddbridge/ddbridge-core.c: In function ‘bpsnr_show’: drivers/media/pci/ddbridge/ddbridge-core.c:3491:13: warning: comparison is always false due to limited range of data type [-Wtype-limits] Fix this by changing the type of snr to unsigned char. Cc: Ralph Metzler Signed-off-by: Daniel Scheller Tested-by: Richard Scobie Tested-by: Jasmin Jessich Tested-by: Dietmar Spingler Tested-by: Manfred Knick --- drivers/media/pci/ddbridge/ddbridge-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c b/drivers/media/pci/ddbridge/ddbridge-core.c index 1ffcf23c63ed..ace06fcdd0cf 100644 --- a/drivers/media/pci/ddbridge/ddbridge-core.c +++ b/drivers/media/pci/ddbridge/ddbridge-core.c @@ -3251,7 +3251,7 @@ static ssize_t bpsnr_show(struct device *device, struct device_attribute *attr, char *buf) { struct ddb *dev = dev_get_drvdata(device); - char snr[32]; + unsigned char snr[32]; if (!dev->i2c_num) return 0;