From patchwork Sat Jul 29 11:28:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 9869893 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8A17560382 for ; Sat, 29 Jul 2017 11:30:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84081288D3 for ; Sat, 29 Jul 2017 11:30:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 76E5B288E6; Sat, 29 Jul 2017 11:30:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A175B288D3 for ; Sat, 29 Jul 2017 11:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbdG2L3K (ORCPT ); Sat, 29 Jul 2017 07:29:10 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36498 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753750AbdG2L3G (ORCPT ); Sat, 29 Jul 2017 07:29:06 -0400 Received: by mail-wm0-f65.google.com with SMTP id d40so1134856wma.3 for ; Sat, 29 Jul 2017 04:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=y0VlDtptb950h8w08lAiRi34Q5gR/Ai1K9GDQZlmyDE=; b=bbLsvnH3ppIfv5+US/58WuQ4pPyczzy1DuiX2NM0t7d6gokcJZss9rFeGJ6AQgPlDk XIQQeIlw6tHqgmx6LZ79rJh6nmebG9MWfB/3UZ/Do+fwMrHBOOSYAVrhdd3UXkDSgMAb Ts1Peq+3DCvxhV3gVtm0DEg5Ita9t0sYCh2LoW9YewAd8jESgenGc6yWZaSwQxKVqh/b UdXhH2vo/se3iWgXQlXGDDMVty6opfKKkvahY40bChh5poYZ8kuXqcgGNFaU0xMss7Ys JGapq9SDWSDOrgxWOG9MjK9s9BXjsC0Xz3K0I/qF56c8Xa1Aqk3spBYqAPpQgo6Cdlno TdZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=y0VlDtptb950h8w08lAiRi34Q5gR/Ai1K9GDQZlmyDE=; b=Aq2TV+sIGP5n34dzxcEdsX1QHKN3YddmXkVQa6hsv3m4zD8/TlwydYdzSwZ4K54Wzk RGsbOG3DKVphz1oqx8hbITAHTQcWPTvDi0I89K1DrgOlo7kxV9DmrJFKmqs04itala/i fomXp5eXqVjMJBa4fh7AXXHRrPXxim1ok3raxIBWN4LyH36OwWEMVpbjtAfe7nqDl8Pe nTYPWTCxztrSFynWv14hoCsmjjWffUOv6gIBwVMQo3A1Ty0TtAiTVT08T5vU3kQRq9xT MhD/k3tx3cGQ6T9VPUXszRLLNTM+3nJ4t77sfVOBsz6rlbxep5rGjxWktTaiQTMJrNiH EwTA== X-Gm-Message-State: AIVw110f2N0V3sCzHHsJbNs0Ptffltgdeuqn4YJwMZ0cGYveuNDP9yV2 2rhaFhmnZvIotcMm X-Received: by 10.28.113.221 with SMTP id d90mr7809344wmi.49.1501327744786; Sat, 29 Jul 2017 04:29:04 -0700 (PDT) Received: from dvbdev.wuest.de (ip-84-118-193-88.unity-media.net. [84.118.193.88]) by smtp.gmail.com with ESMTPSA id o68sm6220054wmi.21.2017.07.29.04.29.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 29 Jul 2017 04:29:04 -0700 (PDT) From: Daniel Scheller To: linux-media@vger.kernel.org, mchehab@kernel.org, mchehab@s-opensource.com Cc: r.scobie@clear.net.nz, jasmin@anw.at, d_spingler@freenet.de, Manfred.Knick@t-online.de, rjkm@metzlerbros.de Subject: [PATCH v2 13/14] [media] ddbridge: Kconfig option to control the MSI modparam default Date: Sat, 29 Jul 2017 13:28:47 +0200 Message-Id: <20170729112848.707-14-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170729112848.707-1-d.scheller.oss@gmail.com> References: <20170729112848.707-1-d.scheller.oss@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller It is known that MSI interrupts - while working quite well so far - can still cause issues on some hardware platforms (causing I2C timeouts due to unhandled interrupts). The msi variable/option is set to 1 by default. So, add a Kconfig option prefixed with "EXPERIMENTAL" that will control the default value of that modparam, defaulting to off for a better user experience and (guaranteed) stable operation "per default". Cc: Ralph Metzler Signed-off-by: Daniel Scheller Tested-by: Richard Scobie Tested-by: Jasmin Jessich Tested-by: Dietmar Spingler Tested-by: Manfred Knick --- drivers/media/pci/ddbridge/Kconfig | 15 +++++++++++++++ drivers/media/pci/ddbridge/ddbridge-main.c | 11 +++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/ddbridge/Kconfig b/drivers/media/pci/ddbridge/Kconfig index c79a58fa5fc3..1330b2ecc72a 100644 --- a/drivers/media/pci/ddbridge/Kconfig +++ b/drivers/media/pci/ddbridge/Kconfig @@ -26,3 +26,18 @@ config DVB_DDBRIDGE - CineS2 V7/V7A and DuoFlex S2 V4 (ST STV0910-based) Say Y if you own such a card and want to use it. + +config DVB_DDBRIDGE_MSIENABLE + bool "Enable Message Signaled Interrupts (MSI) per default (EXPERIMENTAL)" + depends on DVB_DDBRIDGE + depends on PCI_MSI + default n + ---help--- + Use PCI MSI (Message Signaled Interrupts) per default. Enabling this + might lead to I2C errors originating from the bridge in conjunction + with certain SATA controllers, requiring a reload of the ddbridge + module. MSI can still be disabled by passing msi=0 as option, as + this will just change the msi option default value. + + If you're unsure, concerned about stability and don't want to pass + module options in case of troubles, say N. diff --git a/drivers/media/pci/ddbridge/ddbridge-main.c b/drivers/media/pci/ddbridge/ddbridge-main.c index 5094d2ef79d6..5a930a6e9fb2 100644 --- a/drivers/media/pci/ddbridge/ddbridge-main.c +++ b/drivers/media/pci/ddbridge/ddbridge-main.c @@ -47,10 +47,17 @@ MODULE_PARM_DESC(adapter_alloc, "0-one adapter per io, 1-one per tab with io, 2-one per tab, 3-one for all"); #ifdef CONFIG_PCI_MSI +#ifdef CONFIG_DVB_DDBRIDGE_MSIENABLE int msi = 1; +#else +int msi; +#endif module_param(msi, int, 0444); -MODULE_PARM_DESC(msi, - " Control MSI interrupts: 0-disable, 1-enable (default)"); +#ifdef CONFIG_DVB_DDBRIDGE_MSIENABLE +MODULE_PARM_DESC(msi, "Control MSI interrupts: 0-disable, 1-enable (default)"); +#else +MODULE_PARM_DESC(msi, "Control MSI interrupts: 0-disable (default), 1-enable"); +#endif #endif int ci_bitrate = 70000;