| Message ID | 20170806085655.dkaq7hqpyzrc3abj@gofer.mess.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sean! On Sun, Aug 06, 2017 at 09:56:55AM +0100, Sean Young wrote: > The rc device is created before the input device, so if ir-keytable runs > too early the input device does not exist yet. > > Ensure that rule fires on creation of a rc device's input device. > > Note that this also prevents udev from starting ir-keytable on an > transmit only device, which has no input device. > > Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Matthias Reichl <hias@horus.com> One comment though, see below > --- > utils/keytable/70-infrared.rules | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > Matthias, can I have your Signed-off-by please? Thank you. > > > diff --git a/utils/keytable/70-infrared.rules b/utils/keytable/70-infrared.rules > index afffd951..b3531727 100644 > --- a/utils/keytable/70-infrared.rules > +++ b/utils/keytable/70-infrared.rules > @@ -1,4 +1,12 @@ > # Automatically load the proper keymaps after the Remote Controller device > # creation. The keycode tables rules should be at /etc/rc_maps.cfg > > -ACTION=="add", SUBSYSTEM=="rc", RUN+="/usr/bin/ir-keytable -a /etc/rc_maps.cfg -s $name" > +ACTION!="add", SUBSYSTEMS!="rc", GOTO="rc_dev_end" This line doesn't quite what we want it to do. As SUBSYSTEMS!="rc" is basically a no-op and would only be evaluated on change/remove events anyways that line boils down to ACTION!="add", GOTO="rc_dev_end" and the following rules are evaluated on all add events. While that'll still work it'll do unnecessary work, like importing rc_sydev for all input devices and could bite us (or users) later if we change/extend the ruleset. Better do it like in my original comment (using positive logic and a GOTO="begin") or use ACTION!="add", GOTO="rc_dev_end" and add SUBSYSTEMS=="rc" to the IMPORT and RUN rules below. so long, Hias > + > +SUBSYSTEM=="rc", ENV{rc_sysdev}="$name" > + > +SUBSYSTEM=="input", IMPORT{parent}="rc_sysdev" > + > +KERNEL=="event[0-9]*", ENV{rc_sysdev}=="?*", RUN+="/usr/bin/ir-keytable -a /etc/rc_maps.cfg -s $env{rc_sysdev}" > + > +LABEL="rc_dev_end" > -- > 2.11.0 >
diff --git a/utils/keytable/70-infrared.rules b/utils/keytable/70-infrared.rules index afffd951..b3531727 100644 --- a/utils/keytable/70-infrared.rules +++ b/utils/keytable/70-infrared.rules @@ -1,4 +1,12 @@ # Automatically load the proper keymaps after the Remote Controller device # creation. The keycode tables rules should be at /etc/rc_maps.cfg -ACTION=="add", SUBSYSTEM=="rc", RUN+="/usr/bin/ir-keytable -a /etc/rc_maps.cfg -s $name" +ACTION!="add", SUBSYSTEMS!="rc", GOTO="rc_dev_end" + +SUBSYSTEM=="rc", ENV{rc_sysdev}="$name" + +SUBSYSTEM=="input", IMPORT{parent}="rc_sysdev" + +KERNEL=="event[0-9]*", ENV{rc_sysdev}=="?*", RUN+="/usr/bin/ir-keytable -a /etc/rc_maps.cfg -s $env{rc_sysdev}" + +LABEL="rc_dev_end"
The rc device is created before the input device, so if ir-keytable runs too early the input device does not exist yet. Ensure that rule fires on creation of a rc device's input device. Note that this also prevents udev from starting ir-keytable on an transmit only device, which has no input device. Signed-off-by: Sean Young <sean@mess.org> --- utils/keytable/70-infrared.rules | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Matthias, can I have your Signed-off-by please? Thank you.