From patchwork Tue Aug 8 12:56:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 9888109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0C66F601EB for ; Tue, 8 Aug 2017 12:56:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F21A0288AE for ; Tue, 8 Aug 2017 12:56:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E5433288C3; Tue, 8 Aug 2017 12:56:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 68F91288B9 for ; Tue, 8 Aug 2017 12:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752556AbdHHM43 (ORCPT ); Tue, 8 Aug 2017 08:56:29 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:47380 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbdHHM4R (ORCPT ); Tue, 8 Aug 2017 08:56:17 -0400 Received: from avalon.bb.dnainternet.fi (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by galahad.ideasonboard.com (Postfix) with ESMTPSA id D1AFD20226; Tue, 8 Aug 2017 14:55:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1502196910; bh=8+o/QD6nipGxghb45nKEulsTwWHOKpjgbWRBixMA4Cw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B0ofyd09GX1CTrd22dqLSLunNBBDhq1nP/UnUaxiSWi7m4S+1VvhPOTRCt8fGKuwb tndovT+E2vGb+mVD+CexWtYZtugTfHijIftHfinB2MkiTcfgLFSJARx0Wsudp6w+qx fI66auVXXj45LZqx/N+OCxAN/ZCtQTwCbnEOE0iY= From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, Jim Lin Subject: [PATCH 1/5] uvcvideo: Fix incorrect timeout for Get Request Date: Tue, 8 Aug 2017 15:56:20 +0300 Message-Id: <20170808125624.11328-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170808125624.11328-1-laurent.pinchart@ideasonboard.com> References: <20170808125624.11328-1-laurent.pinchart@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jim Lin Section 9.2.6.4 of USB 2.0/3.x specification describes that "device must be able to return the first data packet to host within 500 ms of receipt of the request. For subsequent data packet, if any, the device must be able to return them within 500 ms". This is to fix incorrect timeout and change it from 300 ms to 500 ms to meet the timing specified by specification for Get Request. Signed-off-by: Jim Lin Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvcvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h index 15e415e32c7f..296b69bb3fb2 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -166,7 +166,7 @@ /* Maximum status buffer size in bytes of interrupt URB. */ #define UVC_MAX_STATUS_SIZE 16 -#define UVC_CTRL_CONTROL_TIMEOUT 300 +#define UVC_CTRL_CONTROL_TIMEOUT 500 #define UVC_CTRL_STREAMING_TIMEOUT 5000 /* Maximum allowed number of control mappings per device */