From patchwork Tue Aug 22 23:26:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 9916355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 536B3603FA for ; Tue, 22 Aug 2017 23:29:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 46E2126256 for ; Tue, 22 Aug 2017 23:29:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3BA3E27853; Tue, 22 Aug 2017 23:29:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82A1926256 for ; Tue, 22 Aug 2017 23:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752982AbdHVX3P (ORCPT ); Tue, 22 Aug 2017 19:29:15 -0400 Received: from smtp-3.sys.kth.se ([130.237.48.192]:56074 "EHLO smtp-3.sys.kth.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752851AbdHVX2s (ORCPT ); Tue, 22 Aug 2017 19:28:48 -0400 Received: from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-3.sys.kth.se (Postfix) with ESMTP id DFAE23680; Wed, 23 Aug 2017 01:28:46 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-3.sys.kth.se ([127.0.0.1]) by smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NLGo3EEmLejb; Wed, 23 Aug 2017 01:28:46 +0200 (CEST) X-KTH-Auth: niso [89.233.230.99] X-KTH-mail-from: niklas.soderlund+renesas@ragnatech.se Received: from bismarck.berto.se (unknown [89.233.230.99]) by smtp-3.sys.kth.se (Postfix) with ESMTPSA id C2A11365E; Wed, 23 Aug 2017 01:28:45 +0200 (CEST) From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= To: Laurent Pinchart , Hans Verkuil Cc: Kieran Bingham , Sakari Ailus , tomoharu.fukawa.eb@renesas.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, =?UTF-8?q?Niklas=20S=C3=B6derlund?= Subject: [PATCH v6 19/25] rcar-vin: add group allocator functions Date: Wed, 23 Aug 2017 01:26:34 +0200 Message-Id: <20170822232640.26147-20-niklas.soderlund+renesas@ragnatech.se> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170822232640.26147-1-niklas.soderlund+renesas@ragnatech.se> References: <20170822232640.26147-1-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In media controller mode all VIN instances needs to be part of the same media graph. There is also a need to each VIN instance to know and in some cases be able to communicate with other VIN instances. Add a allocator framework where the first VIN instance to be probed creates a shared data structure and creates a media device. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil --- drivers/media/platform/rcar-vin/rcar-core.c | 179 +++++++++++++++++++++++++++- drivers/media/platform/rcar-vin/rcar-vin.h | 38 ++++++ 2 files changed, 216 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c index dd0525f2ba336bc2..4218a73eb6885486 100644 --- a/drivers/media/platform/rcar-vin/rcar-core.c +++ b/drivers/media/platform/rcar-vin/rcar-core.c @@ -20,11 +20,170 @@ #include #include #include +#include #include #include "rcar-vin.h" +/* ----------------------------------------------------------------------------- + * Gen3 CSI2 Group Allocator + */ + +static int rvin_group_read_id(struct rvin_dev *vin, struct device_node *np) +{ + u32 val; + int ret; + + ret = of_property_read_u32(np, "renesas,id", &val); + if (ret) { + vin_err(vin, "%s: No renesas,id property found\n", + of_node_full_name(np)); + return -EINVAL; + } + + if (val >= RCAR_VIN_NUM) { + vin_err(vin, "%s: Invalid renesas,id '%u'\n", + of_node_full_name(np), val); + return -EINVAL; + } + + return val; +} + +static DEFINE_MUTEX(rvin_group_lock); +static struct rvin_group *rvin_group_data; + +static void rvin_group_release(struct kref *kref) +{ + struct rvin_group *group = + container_of(kref, struct rvin_group, refcount); + + mutex_lock(&rvin_group_lock); + + media_device_unregister(&group->mdev); + media_device_cleanup(&group->mdev); + + rvin_group_data = NULL; + + mutex_unlock(&rvin_group_lock); + + kfree(group); +} + +static struct rvin_group *__rvin_group_allocate(struct rvin_dev *vin) +{ + struct rvin_group *group; + + if (rvin_group_data) { + group = rvin_group_data; + kref_get(&group->refcount); + vin_dbg(vin, "%s: get group=%p\n", __func__, group); + return group; + } + + group = kzalloc(sizeof(*group), GFP_KERNEL); + if (!group) + return NULL; + + kref_init(&group->refcount); + rvin_group_data = group; + + vin_dbg(vin, "%s: alloc group=%p\n", __func__, group); + return group; +} + +static int rvin_group_add_vin(struct rvin_dev *vin) +{ + int ret; + + ret = rvin_group_read_id(vin, vin->dev->of_node); + if (ret < 0) + return ret; + + mutex_lock(&vin->group->lock); + + if (vin->group->vin[ret]) { + mutex_unlock(&vin->group->lock); + vin_err(vin, "VIN number %d already occupied\n", ret); + return -EINVAL; + } + + vin->group->vin[ret] = vin; + + mutex_unlock(&vin->group->lock); + + vin_dbg(vin, "I'm VIN number %d", ret); + + return 0; +} + +static int rvin_group_allocate(struct rvin_dev *vin) +{ + struct rvin_group *group; + struct media_device *mdev; + int ret; + + mutex_lock(&rvin_group_lock); + + group = __rvin_group_allocate(vin); + if (!group) { + mutex_unlock(&rvin_group_lock); + return -ENOMEM; + } + + /* Init group data if its not already initialized */ + mdev = &group->mdev; + if (!mdev->dev) { + mutex_init(&group->lock); + mdev->dev = vin->dev; + + strlcpy(mdev->driver_name, "Renesas VIN", + sizeof(mdev->driver_name)); + strlcpy(mdev->model, vin->dev->of_node->name, + sizeof(mdev->model)); + strlcpy(mdev->bus_info, of_node_full_name(vin->dev->of_node), + sizeof(mdev->bus_info)); + media_device_init(mdev); + + ret = media_device_register(mdev); + if (ret) { + vin_err(vin, "Failed to register media device\n"); + kref_put(&group->refcount, rvin_group_release); + mutex_unlock(&rvin_group_lock); + return ret; + } + } + + vin->group = group; + vin->v4l2_dev.mdev = mdev; + + ret = rvin_group_add_vin(vin); + if (ret) { + kref_put(&group->refcount, rvin_group_release); + mutex_unlock(&rvin_group_lock); + return ret; + } + + mutex_unlock(&rvin_group_lock); + + return 0; +} + +static void rvin_group_delete(struct rvin_dev *vin) +{ + unsigned int i; + + mutex_lock(&vin->group->lock); + for (i = 0; i < RCAR_VIN_NUM; i++) + if (vin->group->vin[i] == vin) + vin->group->vin[i] = NULL; + mutex_unlock(&vin->group->lock); + + vin_dbg(vin, "%s: group=%p\n", __func__, &vin->group); + kref_put(&vin->group->refcount, rvin_group_release); +} + /* ----------------------------------------------------------------------------- * Async notifier */ @@ -283,12 +442,27 @@ static int rvin_digital_graph_init(struct rvin_dev *vin) static int rvin_group_init(struct rvin_dev *vin) { + int ret; + + ret = rvin_group_allocate(vin); + if (ret) + return ret; + /* All our sources are CSI-2 */ vin->mbus_cfg.type = V4L2_MBUS_CSI2; vin->mbus_cfg.flags = 0; vin->pad.flags = MEDIA_PAD_FL_SINK; - return media_entity_pads_init(&vin->vdev.entity, 1, &vin->pad); + ret = media_entity_pads_init(&vin->vdev.entity, 1, &vin->pad); + if (ret) + goto error_group; + + return 0; + +error_group: + rvin_group_delete(vin); + + return ret; } /* ----------------------------------------------------------------------------- @@ -416,6 +590,9 @@ static int rcar_vin_remove(struct platform_device *pdev) rvin_v4l2_remove(vin); + if (vin->info->use_mc) + rvin_group_delete(vin); + rvin_dma_remove(vin); return 0; diff --git a/drivers/media/platform/rcar-vin/rcar-vin.h b/drivers/media/platform/rcar-vin/rcar-vin.h index 9c47669669c0469c..88683aaee3b6acd5 100644 --- a/drivers/media/platform/rcar-vin/rcar-vin.h +++ b/drivers/media/platform/rcar-vin/rcar-vin.h @@ -17,6 +17,8 @@ #ifndef __RCAR_VIN__ #define __RCAR_VIN__ +#include + #include #include #include @@ -30,6 +32,9 @@ /* Address alignment mask for HW buffers */ #define HW_BUFFER_MASK 0x7f +/* Max number on VIN instances that can be in a system */ +#define RCAR_VIN_NUM 8 + enum chip_id { RCAR_H1, RCAR_M1, @@ -37,6 +42,15 @@ enum chip_id { RCAR_GEN3, }; +enum rvin_csi_id { + RVIN_CSI20, + RVIN_CSI21, + RVIN_CSI40, + RVIN_CSI41, + RVIN_CSI_MAX, + RVIN_NC, /* Not Connected */ +}; + /** * STOPPED - No operation in progress * RUNNING - Operation in progress have buffers @@ -75,6 +89,8 @@ struct rvin_graph_entity { unsigned int sink_pad; }; +struct rvin_group; + /** * struct rvin_info - Information about the particular VIN implementation * @chip: type of VIN chip @@ -103,6 +119,7 @@ struct rvin_info { * @notifier: V4L2 asynchronous subdevs notifier * @digital: entity in the DT for local digital subdevice * + * @group: Gen3 CSI group * @pad: pad for media controller * * @lock: protects @queue @@ -134,6 +151,7 @@ struct rvin_dev { struct v4l2_async_notifier notifier; struct rvin_graph_entity digital; + struct rvin_group *group; struct media_pad pad; struct mutex lock; @@ -162,6 +180,26 @@ struct rvin_dev { #define vin_warn(d, fmt, arg...) dev_warn(d->dev, fmt, ##arg) #define vin_err(d, fmt, arg...) dev_err(d->dev, fmt, ##arg) +/** + * struct rvin_group - VIN CSI2 group information + * @refcount: number of VIN instances using the group + * + * @mdev: media device which represents the group + * + * @lock: protects the vin and csi members + * @vin: VIN instances which are part of the group + * @csi: CSI-2 entities that are part of the group + */ +struct rvin_group { + struct kref refcount; + + struct media_device mdev; + + struct mutex lock; + struct rvin_dev *vin[RCAR_VIN_NUM]; + struct rvin_graph_entity csi[RVIN_CSI_MAX]; +}; + int rvin_dma_probe(struct rvin_dev *vin, int irq); void rvin_dma_remove(struct rvin_dev *vin);