From patchwork Wed Aug 23 13:30:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9917379 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0F7A9603FA for ; Wed, 23 Aug 2017 13:31:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 018212856E for ; Wed, 23 Aug 2017 13:31:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EA88E28990; Wed, 23 Aug 2017 13:31:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B175F2898B for ; Wed, 23 Aug 2017 13:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754001AbdHWNa5 (ORCPT ); Wed, 23 Aug 2017 09:30:57 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:56571 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753973AbdHWNa5 (ORCPT ); Wed, 23 Aug 2017 09:30:57 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0M4VfU-1dLApn197E-00yhg3; Wed, 23 Aug 2017 15:30:47 +0200 From: Arnd Bergmann To: Laurent Pinchart , Mauro Carvalho Chehab Cc: Arnd Bergmann , Sakari Ailus , Pavel Machek , Sebastian Reichel , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: omap3isp: fix uninitialized variable use Date: Wed, 23 Aug 2017 15:30:19 +0200 Message-Id: <20170823133044.686146-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Mremp0+xmJLdQJ0YmsZZUbIMTlqwcAAaOWNujvm1lfC6OfX3SoZ HuoLjwHUr0EA7VTBuEibbxTRhCwFB76zV2YsgjKxR58NdocFFMpsQOKkWUzb53m5kl+/TLN KO9/6lqZ0C/L/NqhipYayo4iIERwqS6Y4WQc7Qq4Sx6rrkKEbYLQHuAcLMHjooDCSKN6CIm 7TARUtSy88ErZpruu9/9g== X-UI-Out-Filterresults: notjunk:1; V01:K0:LEAw2dL16oA=:cGyw+sOXLyGUWIozgLgxKg N2nKzZksTLRqKCOs+5USwyZPmptB+TMdxNFw34Y2jATp322JceZ02c5yB5TcLN+1UX0ZgT5gi kZ0GSoI3uJSGdB2KqZKbtvA2FiFx2j6sWvxZH2X7q+zoh5QcOiwkFv6NYIDdXe71jqKieUyq1 ixTpb79E7XhbfiwEfXqo7Tkk5wGDqIOOyXCZLVoi1YnH4wEBmcqBV2aI3g9CLQ9MlHq1d0YMW oOpV2X4yWt+JWP4VTDXeI+b7A1yCpxAgPClnSyqPJe65HIbv3PPrbNqcNXA5C3Z+xaTvGDp5h h9R/I5QGjgUbCi/NjMSCrQMk081SaKmif8vKM6MYFJfQEFFEoPEg0iI62ZLZnsH7yUckzh1O1 m6JmiyCYhsyuUnDNSwkjD9UcjrYo9lg2jtvK71zMu5b3RbHUjdpyR4roUJcssxESh+eVdx3j6 lcj93ZasKNTZkdGVL4ao4z5/j7pBlH/1LuxP8JyF5bLMDy6DkTmUnwdf8gLEEj4P8vL5DRG2q FytqqKuwTWtaKNE7NwAFbtP4xEQgLxjmWISGEHSKW6yfesmK+tA8IFsXQmw3NOiwuV3dTFu6A uPL1RkVPLzlkKCRzKmUV6gyTy8eXieuByOWMOBHv7oz0z+9CGL75rapwr1MKdP/NhVGHuNbj1 IDrET7sNNdUB9VPQfj1vEQzktZnG8xHW4/p8j4U3M00KbqkxxixkDkqFPIDC8Uw16jrsTYe3/ yYZ7wVu7FG4wWmXR2mMNMX8ehwooOSLbN0TXew== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A debug printk statement was copied incorrectly into the new csi1 parser code and causes a warning there: drivers/media/platform/omap3isp/isp.c: In function 'isp_probe': include/linux/dynamic_debug.h:134:3: error: 'i' may be used uninitialized in this function [-Werror=maybe-uninitialized] Since there is only one lane, the index is never set. This changes the debug print to always print a zero instead, keeping the original format of the message. Fixes: 9211434bad30 ("media: omap3isp: Parse CSI1 configuration from the device tree") Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 83aea08b832d..30c825bf80d9 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2092,7 +2092,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, buscfg->bus.ccp2.lanecfg.data[0].pol = vep.bus.mipi_csi1.lane_polarity[1]; - dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i, + dev_dbg(dev, "data lane 0 polarity %u, pos %u\n", buscfg->bus.ccp2.lanecfg.data[0].pol, buscfg->bus.ccp2.lanecfg.data[0].pos);