| Message ID | 20171004215051.13385-3-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Thu, Oct 05, 2017 at 12:50:21AM +0300, Sakari Ailus wrote: > v4l2_async_cleanup() is called when the async sub-device is unbound from > the media device. As the pointer is set by the driver registering the > async sub-device, leave the pointer as set by the driver. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> -- Sebastian > drivers/media/v4l2-core/v4l2-async.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index 60a1a50b9537..21c748bf3a7b 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -134,7 +134,6 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd) > /* Subdevice driver will reprobe and put the subdev back onto the list */ > list_del_init(&sd->async_list); > sd->asd = NULL; > - sd->dev = NULL; > } > > int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, > -- > 2.11.0 >
On 04/10/17 23:50, Sakari Ailus wrote: > v4l2_async_cleanup() is called when the async sub-device is unbound from > the media device. As the pointer is set by the driver registering the > async sub-device, leave the pointer as set by the driver. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > --- > drivers/media/v4l2-core/v4l2-async.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index 60a1a50b9537..21c748bf3a7b 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -134,7 +134,6 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd) > /* Subdevice driver will reprobe and put the subdev back onto the list */ > list_del_init(&sd->async_list); > sd->asd = NULL; > - sd->dev = NULL; > } > > int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, >
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index 60a1a50b9537..21c748bf3a7b 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c @@ -134,7 +134,6 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd) /* Subdevice driver will reprobe and put the subdev back onto the list */ list_del_init(&sd->async_list); sd->asd = NULL; - sd->dev = NULL; } int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,
v4l2_async_cleanup() is called when the async sub-device is unbound from the media device. As the pointer is set by the driver registering the async sub-device, leave the pointer as set by the driver. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/v4l2-core/v4l2-async.c | 1 - 1 file changed, 1 deletion(-)