| Message ID | 20171020215012.20646-10-gustavo@padovan.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/20/2017 11:50 PM, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.padovan@collabora.com> > > By setting this member on vb2_queue the driver tell vb2 core that > it requires the buffers queued in QBUF to be queued with same order to the > driver. As we discussed in Prague this appears to be an unnecessary flag. In fact, as far as I can tell it isn't set at all in this patch series. Regards, Hans > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com> > --- > include/media/videobuf2-core.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h > index 6dd3f0181107..fc333e10e7d8 100644 > --- a/include/media/videobuf2-core.h > +++ b/include/media/videobuf2-core.h > @@ -505,6 +505,9 @@ struct vb2_buf_ops { > * the same order they are dequeued from the driver. The default > * is not ordered unless the driver sets this flag. As of now it > * is mandatory for using explicit fences. > + * @ordered_in_vb2: set by the driver to tell vb2 te guarantee the order > + * of buffer queue from userspace with QBUF() until they are > + * queued to the driver. > * @fileio: file io emulator internal data, used only if emulator is active > * @threadio: thread io internal data, used only if thread is active > */ > @@ -558,6 +561,7 @@ struct vb2_queue { > unsigned int copy_timestamp:1; > unsigned int last_buffer_dequeued:1; > unsigned int ordered_in_driver:1; > + unsigned int ordered_in_vb2:1; > > struct vb2_fileio_data *fileio; > struct vb2_threadio_data *threadio; >
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index 6dd3f0181107..fc333e10e7d8 100644 --- a/include/media/videobuf2-core.h +++ b/include/media/videobuf2-core.h @@ -505,6 +505,9 @@ struct vb2_buf_ops { * the same order they are dequeued from the driver. The default * is not ordered unless the driver sets this flag. As of now it * is mandatory for using explicit fences. + * @ordered_in_vb2: set by the driver to tell vb2 te guarantee the order + * of buffer queue from userspace with QBUF() until they are + * queued to the driver. * @fileio: file io emulator internal data, used only if emulator is active * @threadio: thread io internal data, used only if thread is active */ @@ -558,6 +561,7 @@ struct vb2_queue { unsigned int copy_timestamp:1; unsigned int last_buffer_dequeued:1; unsigned int ordered_in_driver:1; + unsigned int ordered_in_vb2:1; struct vb2_fileio_data *fileio; struct vb2_threadio_data *threadio;