| Message ID | 20171112081859.GA19079@embeddedor.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Gustavo, Thank you for the patch. On Sunday, 12 November 2017 10:18:59 EEST Gustavo A. R. Silva wrote: > NULL check before freeing functions like debugfs_remove_recursive > is not needed. "functions like debugfs_remove_recursive" seems a bit vague to me. I'd prefer being more precise here, and say that "debugfs_remove_recursive() accepts a NULL parameter and returns immediately, there's no need for a NULL check in the caller.". > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/media/usb/uvc/uvc_debugfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/usb/uvc/uvc_debugfs.c > b/drivers/media/usb/uvc/uvc_debugfs.c index 368f8f8..6995aeb 100644 > --- a/drivers/media/usb/uvc/uvc_debugfs.c > +++ b/drivers/media/usb/uvc/uvc_debugfs.c > @@ -128,6 +128,5 @@ void uvc_debugfs_init(void) > > void uvc_debugfs_cleanup(void) > { > - if (uvc_debugfs_root_dir != NULL) > - debugfs_remove_recursive(uvc_debugfs_root_dir); > + debugfs_remove_recursive(uvc_debugfs_root_dir); > } There's another occurrence in uvc_debugfs_cleanup_stream(). I'll address it as well in this patch. With that change and the commit message update, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and applied to my tree.
diff --git a/drivers/media/usb/uvc/uvc_debugfs.c b/drivers/media/usb/uvc/uvc_debugfs.c index 368f8f8..6995aeb 100644 --- a/drivers/media/usb/uvc/uvc_debugfs.c +++ b/drivers/media/usb/uvc/uvc_debugfs.c @@ -128,6 +128,5 @@ void uvc_debugfs_init(void) void uvc_debugfs_cleanup(void) { - if (uvc_debugfs_root_dir != NULL) - debugfs_remove_recursive(uvc_debugfs_root_dir); + debugfs_remove_recursive(uvc_debugfs_root_dir); }
NULL check before freeing functions like debugfs_remove_recursive is not needed. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/media/usb/uvc/uvc_debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)