From patchwork Sun Nov 26 13:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 10075347 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2810760353 for ; Sun, 26 Nov 2017 13:00:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E98227CF3 for ; Sun, 26 Nov 2017 13:00:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1278E28978; Sun, 26 Nov 2017 13:00:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1767527CF3 for ; Sun, 26 Nov 2017 13:00:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbdKZNAS (ORCPT ); Sun, 26 Nov 2017 08:00:18 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:38920 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbdKZNAR (ORCPT ); Sun, 26 Nov 2017 08:00:17 -0500 Received: by mail-wm0-f65.google.com with SMTP id x63so29771220wmf.4 for ; Sun, 26 Nov 2017 05:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DPSyXPm10BEX8xjBibefSOBsGPJtj/9L8XxpmnX+Q1U=; b=UdwZggM308nocGVDnWivgxNOAjUwEYkKwldMi1omfG7aJoEiNvec+Lt8pEUglOc2PU HuW68nl39C7Em6Gd6lS/V8T3oTkP/NzJtH4DVE+zyMaV8rN+gA4BZ7zd7MOVxGc4sfja EDfh3t8voAYGoF6HZjQHGV6RmzIK2zwAUikIABvv4EiqiVhWBzL0xLtpMm+soqNRxDPb r+l6aCxmmV4jdtPYjuqwQFNjtm0zx8W9iT6/D5fQphuYSEe8pxx3K0xr/3YKMUS0YNFp wmUdabYL3wwcKcrBcYt+AeNjWJzYygFjmh3r7YtnX8gseu+I8RoVXBFXzmAq+97vWfaa q9cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DPSyXPm10BEX8xjBibefSOBsGPJtj/9L8XxpmnX+Q1U=; b=Rb6hGbu/blHcdVAwZNwVECkiV0Tq50ntvEMlQ7dsH4Wc52U1Sv1SYwmnpwra6QVx1Y 26GSX1PyaAPwCSV31rYPQ1dTxLjQvKy52Hk3W73S/3apwugChd4vmydJUHNN/QjoZ2Hs DJjA8MSykjG52nm4/UP2Kqh1sqhUErrl+1LXbSzNp+53m2CecGQeZS2t1NZAUdkCp3Fk F7L0ZWH5+oK8iFluQSMhjDwZ7CMbwOt7N5r6G070pi0CanKb7Uui6hhjUvyjl7DM3Wds WjsxI8G9IHHDhsUoCRMQaHK12ibpgJIKFNd1ePZnhgqlzjPM8J1S5HU3ycZH+f84un2c 16tw== X-Gm-Message-State: AJaThX7u0cKViwmUjF2tMUH90S5TtFP8NRYTNqssrziL8yq/UybsHg6G keoC9dqsyCVxwj2jqHYtjKD8TQ== X-Google-Smtp-Source: AGs4zMZzyFHLuK3qS9ej2ojLca830vBwZxtQjBglYTJ9sCFYVNMXrZIRHxVkFtIPTMsFlWAa/2FAJA== X-Received: by 10.28.153.150 with SMTP id b144mr13711367wme.93.1511701216274; Sun, 26 Nov 2017 05:00:16 -0800 (PST) Received: from dvbdev.wuest.de (ip-84-118-193-200.unity-media.net. [84.118.193.200]) by smtp.gmail.com with ESMTPSA id o88sm37705234wrc.10.2017.11.26.05.00.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Nov 2017 05:00:15 -0800 (PST) From: Daniel Scheller To: linux-media@vger.kernel.org, mchehab@kernel.org, mchehab@s-opensource.com Cc: rjkm@metzlerbros.de, rascobie@slingshot.co.nz, jasmin@anw.at Subject: [PATCH 4/7] [media] dvb-frontends/stv0910: remove unneeded check/call to get_if_freq Date: Sun, 26 Nov 2017 14:00:06 +0100 Message-Id: <20171126130009.6798-5-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171126130009.6798-1-d.scheller.oss@gmail.com> References: <20171126130009.6798-1-d.scheller.oss@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller The result (if any) isn't used anywhere besides being assigned to a local variable (and the only current companion stv6111 doesn't even implement get_if_frequency()), thus remove the ptr check and the call, and also remove the now unused iffreq variable. Reported-by: Richard Scobie Cc: Ralph Metzler Signed-off-by: Daniel Scheller Tested-by: Richard Scobie --- drivers/media/dvb-frontends/stv0910.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-frontends/stv0910.c index cd247ab9c62d..074374fe00be 100644 --- a/drivers/media/dvb-frontends/stv0910.c +++ b/drivers/media/dvb-frontends/stv0910.c @@ -1273,14 +1273,11 @@ static int set_parameters(struct dvb_frontend *fe) { int stat = 0; struct stv *state = fe->demodulator_priv; - u32 iffreq; struct dtv_frontend_properties *p = &fe->dtv_property_cache; stop(state); if (fe->ops.tuner_ops.set_params) fe->ops.tuner_ops.set_params(fe); - if (fe->ops.tuner_ops.get_if_frequency) - fe->ops.tuner_ops.get_if_frequency(fe, &iffreq); state->symbol_rate = p->symbol_rate; stat = start(state, p); return stat;