From patchwork Wed Dec 6 17:59:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 10096723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D793860210 for ; Wed, 6 Dec 2017 17:59:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEADD28A5A for ; Wed, 6 Dec 2017 17:59:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C386928AC5; Wed, 6 Dec 2017 17:59:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D43328A5A for ; Wed, 6 Dec 2017 17:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbdLFR7X (ORCPT ); Wed, 6 Dec 2017 12:59:23 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33709 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbdLFR7V (ORCPT ); Wed, 6 Dec 2017 12:59:21 -0500 Received: by mail-wr0-f193.google.com with SMTP id v22so4842829wrb.0 for ; Wed, 06 Dec 2017 09:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=GHAsvdVPDV2KSnMAtm6X0nuN2NQ1vTfDCL9LEy2/33c=; b=SlV1qc3v699QitK3WcHnUonjlLFrkBMkOCQ2ht66YVuKA8w8/AR5mVm/msPM6mEvfg CkfviRoAJkt4YRJLKPLaZG3+5nLEBZ8d5P5H9T6J27Q9vfsQ0urDpUkPTCKQMtKQn0j+ 2LWaStt76ij6qtyoOTcp7Mh/thfdkJY0gphEpPipgqrVfB+vnJfDZrxR/FF9xfCkQ+1/ NAWtTIplJrgHZbx9uClSqDSC7vKDiR/IrgrWBRXDPEXlJdSimXFZJzm3HKcpE8ufQN7D ZvkhLzoneavhADNcTyGTjHFiP6KUKvF5aGnygFTKsq8eJyGKQ1e8dCq+wrOmYF6U7NZI asMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=GHAsvdVPDV2KSnMAtm6X0nuN2NQ1vTfDCL9LEy2/33c=; b=VD291swDAn1HyN8spyhZh5hWi7lkmhUNv/m0CiR5nFvD0hRHxzvVDcCbFSYe2Dkixp NLaslqV1GycZkIzVdBp2pPl/8qnAhkfYSwpopJbGxHDVa+PgwlCrikprwyHnCIp14Vvl wmagGyjpw2wffEVp4MKeM3ps1jrFzHF7+/Qq1PuJyR/ges68mTVXAmTAiG3GoYFeGc0P g986ewaGwyfIULme1y4UTCD5RMow9bdEqBp3dQK50QSPzKATrfaZT8qvM8ehsu28TcDd L9hzcwpq5Dskwqpg9BeDpBXOeDlwhlviwczNqD5hJ27l3fWdm1YR64GQeFCITLKrB6a1 pBew== X-Gm-Message-State: AJaThX5kEMyOG1bMzliLA/UI0P3G95if8txm2sZ5CFQkarBnzGn0iV94 NBiDxbSQ0g9U985FWTf/m+xv1A== X-Google-Smtp-Source: AGs4zMYNWf0iYqqHP4c7tTrfL73ruj1GXM+mJPdXuu6GcbrPtNk9X5Ezh1WOHo0/tzosAVTNyHGY6g== X-Received: by 10.223.175.199 with SMTP id y7mr20274161wrd.207.1512583159994; Wed, 06 Dec 2017 09:59:19 -0800 (PST) Received: from dvbdev.wuest.de (ip-84-118-193-200.unity-media.net. [84.118.193.200]) by smtp.gmail.com with ESMTPSA id q16sm2958538wre.46.2017.12.06.09.59.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 09:59:19 -0800 (PST) From: Daniel Scheller To: linux-media@vger.kernel.org, mchehab@kernel.org, mchehab@s-opensource.com Subject: [PATCH 2/2] [media] ddbridge: don't break on single/last port attach failure Date: Wed, 6 Dec 2017 18:59:15 +0100 Message-Id: <20171206175915.20669-3-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171206175915.20669-1-d.scheller.oss@gmail.com> References: <20171206175915.20669-1-d.scheller.oss@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller As all error handling improved quite a bit, don't stop attaching frontends if one of them failed, since - if other tuner modules are connected to the PCIe bridge - other hardware may just work, so lets not break on a single port failure, but rather initialise as much as possible. Ie. if there are issues with a C2T2-equipped PCIe bridge card which has additional DuoFlex modules connected and the bridge generally works, the DuoFlex tuners can still work fine. Also, this only had an effect anyway if the failed device/port was the last one being enumerated. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c b/drivers/media/pci/ddbridge/ddbridge-core.c index 11c5cae92408..b43c40e0bf73 100644 --- a/drivers/media/pci/ddbridge/ddbridge-core.c +++ b/drivers/media/pci/ddbridge/ddbridge-core.c @@ -1962,7 +1962,7 @@ int ddb_ports_attach(struct ddb *dev) } for (i = 0; i < dev->port_num; i++) { port = &dev->port[i]; - ret = ddb_port_attach(port); + ddb_port_attach(port); } return ret; }