From patchwork Mon Dec 11 17:23:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aishwarya Pant X-Patchwork-Id: 10105615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5F99E602D8 for ; Mon, 11 Dec 2017 17:24:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 400E0297DA for ; Mon, 11 Dec 2017 17:24:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 344DF297EB; Mon, 11 Dec 2017 17:24:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB46C297DA for ; Mon, 11 Dec 2017 17:24:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbdLKRYF (ORCPT ); Mon, 11 Dec 2017 12:24:05 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:40937 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbdLKRYE (ORCPT ); Mon, 11 Dec 2017 12:24:04 -0500 Received: by mail-pg0-f65.google.com with SMTP id k15so11372587pgr.7; Mon, 11 Dec 2017 09:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=HRiE/e0QCziAk5JzsaGQUKxAFS4UIOPKwk0kMwKHuRw=; b=p7WZQHqu06LJMKlQ/YA/oL0TSl9SZlPAuuGJvKHa80CXTeMwEn+n02QUZxxiSFITCQ MJomxgudkOvWEfujAxzulVweBQxglxOh3FR87O5yVXJZoIpdOOzt/KhDGBX7YUTuaQAl olNVuxmD6qDvCv7Rym2MJ+HQTX/dRbO1b9jCS/ueyl9/uI6Tl/GES/74B75vW4PdHx5+ /0uY30JpZ6WvFpm+mDxv33xk/KsHYEO/zMesMMuaJkLaA42wgZR+uHqvzm0uWL805qnk oDvC3eOgglGByv2MWGIL0va6FmLXk6Clo2g4Dc+fjfG5oPiHEpmE6dr453VajTCJ5wOp lvog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=HRiE/e0QCziAk5JzsaGQUKxAFS4UIOPKwk0kMwKHuRw=; b=aUVqVA/KBqnr8z3x5fm3pi8eQtloY7h11ZM2lZCdqc2chRIKLMKI0v11Z9Ak2z+hyl usiV8k9WMzUVyZiiPO9L+n5csKqidhPu6RhK+irCbeT7lRw2U+FMn90gBhN5H+qU7Jlf n+9eCb6Ln8AnW4Yh53DehdG18D1TkcL+pOXw4gVn83rbzM54VAO8NsTFPG7dRJh2JJds pnOkCDKZInMf31IlLoJotZKwCR1Tg/8fn42EDSZEViTG+aKriqGwWarrPyUtQhWq/4gW kacc7cqOwgXsDtv1A7VPtf8jetFw+mucSnY2USBepZuphURhJyTFYG9s9Rh8E7MOpu4Y dZ/Q== X-Gm-Message-State: AKGB3mJFo3tZnzIJPkNthJkef52Cfvo56ZDCLYeUS04ZUUMZV6Y9EHw+ 46ZfQZvB7ukvTmID2CMmC98= X-Google-Smtp-Source: ACJfBovyVvw7T52aEYm5QeIRffwhYY1K7y4hPdRK9rdh3w9Gi32ZnF7QfDW3neviMd0XebIwuZms3w== X-Received: by 10.99.54.130 with SMTP id d124mr934963pga.108.1513013043386; Mon, 11 Dec 2017 09:24:03 -0800 (PST) Received: from mordor.localdomain ([183.82.23.99]) by smtp.gmail.com with ESMTPSA id s68sm29600359pfj.81.2017.12.11.09.23.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 09:24:02 -0800 (PST) Date: Mon, 11 Dec 2017 22:53:57 +0530 From: Aishwarya Pant To: Alan Cox , Sakari Ailus , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: julia.lawall@lip6.fr Subject: [PATCH] staging: atomisp2: replace DEVICE_ATTR with DEVICE_ATTR_RO Message-ID: <20171211172357.GA20994@mordor.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is a clean-up patch which replaces DEVICE_ATTR() macro with file permission specific DEVICE_ATTR_RO() macro for compaction and readability. Done using coccinelle: @r@ identifier attr, show_fn; declarer name DEVICE_ATTR; @@ DEVICE_ATTR(attr, \(S_IRUGO\|0444\), show_fn, NULL); @script: python p@ attr_show; attr << r.attr; @@ // standardise the show fn name to {attr}_show coccinelle.attr_show = attr + "_show" @@ identifier r.attr, r.show_fn; declarer name DEVICE_ATTR_RO; @@ // change the attr declaration - DEVICE_ATTR(attr, \(S_IRUGO\|0444\), show_fn, NULL); + DEVICE_ATTR_RO(attr); @rr@ identifier r.show_fn, p.attr_show; @@ // rename the show function - show_fn + attr_show (...) { ... } @depends on rr@ identifier r.show_fn, p.attr_show; @@ // rename fn usages - show_fun + attr_show Signed-off-by: Aishwarya Pant --- drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c index a1c81c12718c..4338b8a1309f 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c @@ -158,10 +158,10 @@ static ssize_t dynamic_pool_show(struct device *dev, return ret; }; -static DEVICE_ATTR(active_bo, 0444, active_bo_show, NULL); -static DEVICE_ATTR(free_bo, 0444, free_bo_show, NULL); -static DEVICE_ATTR(reserved_pool, 0444, reserved_pool_show, NULL); -static DEVICE_ATTR(dynamic_pool, 0444, dynamic_pool_show, NULL); +static DEVICE_ATTR_RO(active_bo); +static DEVICE_ATTR_RO(free_bo); +static DEVICE_ATTR_RO(reserved_pool); +static DEVICE_ATTR_RO(dynamic_pool); static struct attribute *sysfs_attrs_ctrl[] = { &dev_attr_active_bo.attr,