| Message ID | 20171214190835.7672-2-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hejssan Niklas, Tack för uppdaterade lappor! On Thu, Dec 14, 2017 at 08:08:21PM +0100, Niklas Söderlund wrote: > To be able to start and stop individual streams of a multiplexed pad the > s_stream operation needs to be both pad and stream aware. Add a new > operation to pad ops to facilitate this. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > include/media/v4l2-subdev.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index a30a94fad8dbacde..7288209338a48fda 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -669,6 +669,9 @@ struct v4l2_subdev_pad_config { > * > * @set_frame_desc: set the low level media bus frame parameters, @fd array > * may be adjusted by the subdev driver to device capabilities. > + * > + * @s_stream: used to notify the driver that a stream will start or has > + * stopped. This is actually the callback which is used to control the stream state. The above suggests that it's a notification of something that has happened (or about to happen). How about: Enable or disable streaming on a sub-device pad. > */ > struct v4l2_subdev_pad_ops { > int (*init_cfg)(struct v4l2_subdev *sd, > @@ -713,6 +716,8 @@ struct v4l2_subdev_pad_ops { > struct v4l2_subdev_routing *route); > int (*set_routing)(struct v4l2_subdev *sd, > struct v4l2_subdev_routing *route); > + int (*s_stream)(struct v4l2_subdev *sd, unsigned int pad, > + unsigned int stream, int enable); How about bool for enable? > }; > > /**
Hej Sakari, Tack för dina kommentarer. On 2017-12-15 13:51:46 +0200, Sakari Ailus wrote: > Hejssan Niklas, > > Tack för uppdaterade lappor! > > On Thu, Dec 14, 2017 at 08:08:21PM +0100, Niklas Söderlund wrote: > > To be able to start and stop individual streams of a multiplexed pad the > > s_stream operation needs to be both pad and stream aware. Add a new > > operation to pad ops to facilitate this. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > > include/media/v4l2-subdev.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > > index a30a94fad8dbacde..7288209338a48fda 100644 > > --- a/include/media/v4l2-subdev.h > > +++ b/include/media/v4l2-subdev.h > > @@ -669,6 +669,9 @@ struct v4l2_subdev_pad_config { > > * > > * @set_frame_desc: set the low level media bus frame parameters, @fd array > > * may be adjusted by the subdev driver to device capabilities. > > + * > > + * @s_stream: used to notify the driver that a stream will start or has > > + * stopped. > > This is actually the callback which is used to control the stream state. > The above suggests that it's a notification of something that has happened > (or about to happen). How about: > > Enable or disable streaming on a sub-device pad. Better, will use it in next version. > > > */ > > struct v4l2_subdev_pad_ops { > > int (*init_cfg)(struct v4l2_subdev *sd, > > @@ -713,6 +716,8 @@ struct v4l2_subdev_pad_ops { > > struct v4l2_subdev_routing *route); > > int (*set_routing)(struct v4l2_subdev *sd, > > struct v4l2_subdev_routing *route); > > + int (*s_stream)(struct v4l2_subdev *sd, unsigned int pad, > > + unsigned int stream, int enable); > > How about bool for enable? I tried to use what the current s_stream uses, but I be happy to make enable a bool in the next version. > > > }; > > > > /** > > -- > Sakari Ailus > sakari.ailus@linux.intel.com
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index a30a94fad8dbacde..7288209338a48fda 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -669,6 +669,9 @@ struct v4l2_subdev_pad_config { * * @set_frame_desc: set the low level media bus frame parameters, @fd array * may be adjusted by the subdev driver to device capabilities. + * + * @s_stream: used to notify the driver that a stream will start or has + * stopped. */ struct v4l2_subdev_pad_ops { int (*init_cfg)(struct v4l2_subdev *sd, @@ -713,6 +716,8 @@ struct v4l2_subdev_pad_ops { struct v4l2_subdev_routing *route); int (*set_routing)(struct v4l2_subdev *sd, struct v4l2_subdev_routing *route); + int (*s_stream)(struct v4l2_subdev *sd, unsigned int pad, + unsigned int stream, int enable); }; /**
To be able to start and stop individual streams of a multiplexed pad the s_stream operation needs to be both pad and stream aware. Add a new operation to pad ops to facilitate this. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- include/media/v4l2-subdev.h | 5 +++++ 1 file changed, 5 insertions(+)