| Message ID | 20180205201002.23621-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Wolfram, Thank you for the patch. On Monday, 5 February 2018 22:09:58 EET Wolfram Sang wrote: > Due to a typo, the mask was destroyed by a comparison instead of a bit > shift. No regression since the mask has not been used yet. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Oops. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and taken in my tree. > --- > Only build tested. To be applied individually per subsystem. > > drivers/media/platform/vsp1/vsp1_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_regs.h > b/drivers/media/platform/vsp1/vsp1_regs.h index > 26c4ffad2f4656..b1912c83a1dae2 100644 > --- a/drivers/media/platform/vsp1/vsp1_regs.h > +++ b/drivers/media/platform/vsp1/vsp1_regs.h > @@ -225,7 +225,7 @@ > #define VI6_RPF_MULT_ALPHA_P_MMD_RATIO (1 << 8) > #define VI6_RPF_MULT_ALPHA_P_MMD_IMAGE (2 << 8) > #define VI6_RPF_MULT_ALPHA_P_MMD_BOTH (3 << 8) > -#define VI6_RPF_MULT_ALPHA_RATIO_MASK (0xff < 0) > +#define VI6_RPF_MULT_ALPHA_RATIO_MASK (0xff << 0) > #define VI6_RPF_MULT_ALPHA_RATIO_SHIFT 0 > > /* ------------------------------------------------------------------------
diff --git a/drivers/media/platform/vsp1/vsp1_regs.h b/drivers/media/platform/vsp1/vsp1_regs.h index 26c4ffad2f4656..b1912c83a1dae2 100644 --- a/drivers/media/platform/vsp1/vsp1_regs.h +++ b/drivers/media/platform/vsp1/vsp1_regs.h @@ -225,7 +225,7 @@ #define VI6_RPF_MULT_ALPHA_P_MMD_RATIO (1 << 8) #define VI6_RPF_MULT_ALPHA_P_MMD_IMAGE (2 << 8) #define VI6_RPF_MULT_ALPHA_P_MMD_BOTH (3 << 8) -#define VI6_RPF_MULT_ALPHA_RATIO_MASK (0xff < 0) +#define VI6_RPF_MULT_ALPHA_RATIO_MASK (0xff << 0) #define VI6_RPF_MULT_ALPHA_RATIO_SHIFT 0 /* -----------------------------------------------------------------------------
Due to a typo, the mask was destroyed by a comparison instead of a bit shift. No regression since the mask has not been used yet. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Only build tested. To be applied individually per subsystem. drivers/media/platform/vsp1/vsp1_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)