From patchwork Wed Mar 7 09:49:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 10263717 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B2E1960247 for ; Wed, 7 Mar 2018 09:50:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6D6429480 for ; Wed, 7 Mar 2018 09:50:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B7B129482; Wed, 7 Mar 2018 09:50:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4660D29480 for ; Wed, 7 Mar 2018 09:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754231AbeCGJt5 (ORCPT ); Wed, 7 Mar 2018 04:49:57 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36410 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbeCGJt4 (ORCPT ); Wed, 7 Mar 2018 04:49:56 -0500 Received: by mail-lf0-f67.google.com with SMTP id g72-v6so2317648lfg.3; Wed, 07 Mar 2018 01:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=jFGUCXAzs3pw02S6MRI8DgHLVgXeF3uKmR3nJ1c7HHE=; b=ccaCyQAk2ZUCryhdB+wUoO47bBl928z/tW+1tcSRLt6kTpPgDEceDuz1ymF+gW9bBl Hv1HMR9BoXcPULrne67XZmAs6pgFE9nTEqYzsJaRNVgrN/nkBOQ39a9Ca/PlLVDOFLPB mDVOOxcKYVA3blwdVnw7/HBAgQpSCCHLXu1zii0D4j9KEblZmKT+r6I/+dqI5M8Vndxo FkKN5w5wT7yGUqaG76zGJp4PDYf5WJFhEfpe4Xz7wJ7jKLk3FhNIoEigohfKr2vDpE2/ Li/JuOpS5W5+VNjwR0AM7WRpV+c+6FKAaFf0xuzjGml8VmRlKu/338KBtopAuHgsXhYK WlAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=jFGUCXAzs3pw02S6MRI8DgHLVgXeF3uKmR3nJ1c7HHE=; b=VvI7BhY1kku/KZAhMhC2q1++ZsuJ5agayj1s9N2K6XpfLdnYNiDVl5gV/k28kATkOF NGzTxfXgEXeg41Q8m1oNcmmOOmuIpenc1/1onrkhvD9LshJvEzi190mhcEl/ckuGp2iJ j493NVr/UDVP/hPu63EOt93/fgICdN7wiqTTqnH3vWgIn1e8s5K+tnkfjmgbgR+G04RN 8080+yKmRgh1DDUgMTAmk3SyW6wwh9zfznpZFOIN+Hdy/KQuZdoSuHgZ6CB2g4NbhHPx EFNsJzuz2D+Y0MC+/4Ikd8GgZ+4bAooQ5AA8NixorHpUc4MY4Rs/bqKVy6INzbVuesLj DvkQ== X-Gm-Message-State: AElRT7HAWU33Dz1PgXeFddAjlaT0IIUzV3T5t1ld32KSSmT6DEW3L49U JA/dXWBTi6ackiQLzvIy+xoG3N9o X-Google-Smtp-Source: AG47ELut2uALKLNalJ/lc/qka61iMqwmMV7czJJDt3t3g/sY9sG+DTn7RgNAfsXBqFA/ToEyrhmPtg== X-Received: by 10.25.239.10 with SMTP id n10mr14467142lfh.8.1520416194419; Wed, 07 Mar 2018 01:49:54 -0800 (PST) Received: from xi.terra (c-8bb2e655.07-184-6d6c6d4.cust.bredbandsbolaget.se. [85.230.178.139]) by smtp.gmail.com with ESMTPSA id e23sm3100336lfi.89.2018.03.07.01.49.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 01:49:53 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.89) (envelope-from ) id 1etVhs-0002O8-R7; Wed, 07 Mar 2018 10:49:56 +0100 From: Johan Hovold To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-usb@vger.kernel.org, Johan Hovold Subject: [PATCH] [media] cpia2_usb: drop bogus interface-release call Date: Wed, 7 Mar 2018 10:49:36 +0100 Message-Id: <20180307094936.9140-1-johan@kernel.org> X-Mailer: git-send-email 2.16.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Drop bogus call to usb_driver_release_interface() from the disconnect() callback. As the interface is already being unbound at this point, usb_driver_release_interface() simply returns early. Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman --- drivers/media/usb/cpia2/cpia2_usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c index f3a1e5b1e57c..b51fc372ca25 100644 --- a/drivers/media/usb/cpia2/cpia2_usb.c +++ b/drivers/media/usb/cpia2/cpia2_usb.c @@ -910,9 +910,6 @@ static void cpia2_usb_disconnect(struct usb_interface *intf) wake_up_interruptible(&cam->wq_stream); } - DBG("Releasing interface\n"); - usb_driver_release_interface(&cpia2_driver, intf); - LOG("CPiA2 camera disconnected.\n"); }