From patchwork Sat Mar 10 00:09:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 10272601 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4537860594 for ; Sat, 10 Mar 2018 00:11:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3389529FB2 for ; Sat, 10 Mar 2018 00:11:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 25A9B2A057; Sat, 10 Mar 2018 00:11:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C2802A044 for ; Sat, 10 Mar 2018 00:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932814AbeCJAKz (ORCPT ); Fri, 9 Mar 2018 19:10:55 -0500 Received: from vsp-unauthed02.binero.net ([195.74.38.227]:23771 "EHLO bin-vsp-out-02.atm.binero.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932856AbeCJAKx (ORCPT ); Fri, 9 Mar 2018 19:10:53 -0500 X-Halon-ID: 75778b95-23f7-11e8-9bc6-005056917f90 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (unknown [89.233.230.99]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA id 75778b95-23f7-11e8-9bc6-005056917f90; Sat, 10 Mar 2018 01:10:37 +0100 (CET) From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= To: Laurent Pinchart , Hans Verkuil , linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, tomoharu.fukawa.eb@renesas.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= Subject: [PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler Date: Sat, 10 Mar 2018 01:09:51 +0100 Message-Id: <20180310000953.25366-2-niklas.soderlund+renesas@ragnatech.se> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180310000953.25366-1-niklas.soderlund+renesas@ragnatech.se> References: <20180310000953.25366-1-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is an error from when the driver where converted from soc-camera. There is absolutely no gain to check the state variable two times to be extra sure if the hardware is stopped. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index 23fdff7a7370842e..b4be75d5009080f7 100644 --- a/drivers/media/platform/rcar-vin/rcar-dma.c +++ b/drivers/media/platform/rcar-vin/rcar-dma.c @@ -916,12 +916,6 @@ static irqreturn_t rvin_irq(int irq, void *data) rvin_ack_interrupt(vin); handled = 1; - /* Nothing to do if capture status is 'STOPPED' */ - if (vin->state == STOPPED) { - vin_dbg(vin, "IRQ while state stopped\n"); - goto done; - } - /* Nothing to do if capture status is 'STOPPING' */ if (vin->state == STOPPING) { vin_dbg(vin, "IRQ while state stopping\n");