| Message ID | 20180408172138.9974-5-tskd08@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Mon, 9 Apr 2018 02:21:37 +0900 tskd08@gmail.com escreveu: > From: Akihiro Tsukada <tskd08@gmail.com> > > As the kernel doc "timers-howto.txt" reads, > short delay with msleep() can take much longer. > In a case of raspbery-pi platform where CONFIG_HZ_100 was set, > it actually affected the init of Friio devices > since it issues lots of i2c transactions with short delay. > > Signed-off-by: Akihiro Tsukada <tskd08@gmail.com> > --- > Changes since v4: > - none > > drivers/media/usb/dvb-usb-v2/gl861.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/gl861.c b/drivers/media/usb/dvb-usb-v2/gl861.c > index ecff0062bfb..cdd7bfcb883 100644 > --- a/drivers/media/usb/dvb-usb-v2/gl861.c > +++ b/drivers/media/usb/dvb-usb-v2/gl861.c > @@ -45,7 +45,7 @@ static int gl861_i2c_msg(struct dvb_usb_device *d, u8 addr, > return -EINVAL; > } > > - msleep(1); /* avoid I2C errors */ > + usleep_range(1000, 2000); /* avoid I2C errors */ Actually, this change is puntual and applies even without patch 3/5. So, I'll apply this one too. So, next time, just patches 3 and 5 will be needed. > > return usb_control_msg(d->udev, usb_rcvctrlpipe(d->udev, 0), req, type, > value, index, rbuf, rlen, 2000); Thanks, Mauro
diff --git a/drivers/media/usb/dvb-usb-v2/gl861.c b/drivers/media/usb/dvb-usb-v2/gl861.c index ecff0062bfb..cdd7bfcb883 100644 --- a/drivers/media/usb/dvb-usb-v2/gl861.c +++ b/drivers/media/usb/dvb-usb-v2/gl861.c @@ -45,7 +45,7 @@ static int gl861_i2c_msg(struct dvb_usb_device *d, u8 addr, return -EINVAL; } - msleep(1); /* avoid I2C errors */ + usleep_range(1000, 2000); /* avoid I2C errors */ return usb_control_msg(d->udev, usb_rcvctrlpipe(d->udev, 0), req, type, value, index, rbuf, rlen, 2000);