From patchwork Wed Apr 18 18:53:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10348791 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C1A9601D7 for ; Wed, 18 Apr 2018 18:53:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B18D2866C for ; Wed, 18 Apr 2018 18:53:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F425287F2; Wed, 18 Apr 2018 18:53:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C19632866C for ; Wed, 18 Apr 2018 18:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbeDRSxT (ORCPT ); Wed, 18 Apr 2018 14:53:19 -0400 Received: from osg.samsung.com ([64.30.133.232]:55725 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbeDRSxS (ORCPT ); Wed, 18 Apr 2018 14:53:18 -0400 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id F157F2FA38; Wed, 18 Apr 2018 11:53:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yS2OY4keShWM; Wed, 18 Apr 2018 11:53:13 -0700 (PDT) Received: from vento.lan (177.41.102.122.dynamic.adsl.gvt.net.br [177.41.102.122]) by osg.samsung.com (Postfix) with ESMTPSA id 72D6B2FA2D; Wed, 18 Apr 2018 11:53:12 -0700 (PDT) Date: Wed, 18 Apr 2018 15:53:09 -0300 From: Mauro Carvalho Chehab To: Daniel Scheller Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , Douglas Fischer , jasmin@anw.at Subject: Re: [PATCH v2 18/19] media: si470x: allow build both USB and I2C at the same time Message-ID: <20180418155309.274fe735@vento.lan> In-Reply-To: <20180418190740.092c2344@perian.wuest.de> References: <9e596fe9e1fd9d2c27ae9abaeb900b2e0cd49011.1522959716.git.mchehab@s-opensource.com> <201804062347.x9zW4zaa%fengguang.wu@intel.com> <20180406134603.40d8d055@vento.lan> <20180418190740.092c2344@perian.wuest.de> Organization: Samsung X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Wed, 18 Apr 2018 19:07:40 +0200 Daniel Scheller escreveu: > Am Fri, 6 Apr 2018 13:46:03 -0300 > schrieb Mauro Carvalho Chehab : > > > Em Sat, 7 Apr 2018 00:21:07 +0800 > > kbuild test robot escreveu: > > > > > Hi Mauro, > > > > > > I love your patch! Yet something to improve: > > > [...] > > > > Fixed patch enclosed. > > > > Thanks, > > Mauro > > > > [PATCH] media: si470x: allow build both USB and I2C at the same time > > > > Currently, either USB or I2C is built. Change it to allow > > having both enabled at the same time. > > > > The main reason is that COMPILE_TEST all[yes/mod]builds will > > now contain all drivers under drivers/media. > > > > Signed-off-by: Mauro Carvalho Chehab > > FWIW, this patch (which seemingly is commit > 58757984ca3c73284a45dd53ac66f1414057cd09 in media_tree.git) seems to break media_build in a way that on my systems only 20 drivers and modules are built now, while it should be in the 650+ modules range. Hans' automated daily testbuilds suffer from the same issue, looking at todays daily build logs (Wednesday.tar.bz2). I personally build against Kernel 4.16.2 on Gentoo. > > This specific commit/patch was found using > > # git bisect good v4.17-rc1 > # git bisect bad media_tree/master > > And, "git revert 58767984..." makes all drivers being built again by > media_build. > > Not sure if there's something other for which this patch acts as the > trigger of if this needs adaption in media_build, though I thought > reporting this doesn't hurt. > > Best regards, > Daniel Scheller Please try this: Thanks, Mauro diff --git a/drivers/media/radio/si470x/Makefile b/drivers/media/radio/si470x/Makefile index 563500823e04..682b3146397e 100644 --- a/drivers/media/radio/si470x/Makefile +++ b/drivers/media/radio/si470x/Makefile @@ -2,6 +2,6 @@ # Makefile for radios with Silicon Labs Si470x FM Radio Receivers # -obj-$(CONFIG_RADIO_SI470X) := radio-si470x-common.o +obj-$(CONFIG_RADIO_SI470X) += radio-si470x-common.o obj-$(CONFIG_USB_SI470X) += radio-si470x-usb.o obj-$(CONFIG_I2C_SI470X) += radio-si470x-i2c.o