From patchwork Mon May 7 15:56:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Miguel Silva X-Patchwork-Id: 10384433 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EB97460236 for ; Mon, 7 May 2018 15:57:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4FD8289BC for ; Mon, 7 May 2018 15:57:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7727289DD; Mon, 7 May 2018 15:57:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61D04289BC for ; Mon, 7 May 2018 15:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbeEGP5o (ORCPT ); Mon, 7 May 2018 11:57:44 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:33960 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761AbeEGP5m (ORCPT ); Mon, 7 May 2018 11:57:42 -0400 Received: by mail-wr0-f196.google.com with SMTP id p18-v6so29326062wrm.1 for ; Mon, 07 May 2018 08:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3OeSCMQTnB5Zbn37nOARIKXFybH8gj/fV34v2WcaUfM=; b=DY5jkJ2igWQmcrSnfRHT3jen+Z6Y7tlZwISSvfKuUkoz+XgyGIXcX1IjwJZZWsYpD3 yCNCYbRjW4Cq9FqLIvWN10wYD9EkQ8S8ANiNgWGzRizwNy20o+i3XF6Np/I7qSvmmyUi CBClJpLzSeuY300+ymTXCJJ2sOlv46V/FBUow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3OeSCMQTnB5Zbn37nOARIKXFybH8gj/fV34v2WcaUfM=; b=Afya3zWLiVcGkCBmk0GYVnFEn6Ud0AsMqbQ/weqj4rt5VorD/o0BJcUtD7Nj3IlQE3 gFm2ELnr5EvaY7UOjE11xDKSOvIn4NbCSnai36oBVI8xGQGQnjUF8Ni95tr8rp53bAOl 3RZyI/p3uSn3uVXzCnTZ/ogDfdg5HzNLii8aVKgtLUlixwfjRIC2KKkEWsEBL7F86ROY X7uLE03y+qamvL5JfetkrrehoqM9+If5wr5hcg7HYUwLACz3iHaCfhVf9N/ovqVV2ESN 2ht7P9fQLYjdDrhbdcm8awmfAnyK/Z2VZW4kFkNt9aw4/7RN44wjltVf4yYggI7aSxps sZpg== X-Gm-Message-State: ALQs6tAv6dfsvTgGD8cxuYTH8kFwdmGyewjD4yLMwVvhOPPqhvvbD5v3 XeePowgI48PYG3lf6h8VMPlyiA== X-Google-Smtp-Source: AB8JxZpbS9Cf/18dAtVjqwbGbWU8+9iBiJ51KWdsd/yzfM1sFZgrhJxkoadyaKDTS8k/xRvoA21SzA== X-Received: by 2002:adf:86ac:: with SMTP id 41-v6mr28757047wrx.260.1525708660884; Mon, 07 May 2018 08:57:40 -0700 (PDT) Received: from arch-late.local (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id y42-v6sm32294807wry.21.2018.05.07.08.57.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 08:57:40 -0700 (PDT) From: Rui Miguel Silva To: mchehab@kernel.org, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl, Rob Herring Cc: linux-media@vger.kernel.org, Fabio Estevam , devicetree@vger.kernel.org, Ryan Harkin , Rui Miguel Silva Subject: [PATCH 3/4] media: ov2680: rename powerdown gpio and fix polarity Date: Mon, 7 May 2018 16:56:54 +0100 Message-Id: <20180507155655.1555-4-rui.silva@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180507155655.1555-1-rui.silva@linaro.org> References: <20180507155655.1555-1-rui.silva@linaro.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rename the power control gpio to reset, since it is the same, and fix the polarity code since this gpio is active at low and not at high as controlled before. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/ov2680.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c index cc3d06096d51..8962b397211a 100644 --- a/drivers/media/i2c/ov2680.c +++ b/drivers/media/i2c/ov2680.c @@ -98,7 +98,7 @@ struct ov2680_dev { struct clk *xvclk; u32 xvclk_freq; - struct gpio_desc *pwdn_gpio; + struct gpio_desc *reset_gpio; struct mutex lock; /* protect members */ bool mode_pending_changes; @@ -295,19 +295,19 @@ static int ov2680_load_regs(struct ov2680_dev *sensor, static void ov2680_power_up(struct ov2680_dev *sensor) { - if (!sensor->pwdn_gpio) + if (!sensor->reset_gpio) return; - gpiod_set_value(sensor->pwdn_gpio, 1); + gpiod_set_value(sensor->reset_gpio, 0); usleep_range(5000, 10000); } static void ov2680_power_down(struct ov2680_dev *sensor) { - if (!sensor->pwdn_gpio) + if (!sensor->reset_gpio) return; - gpiod_set_value(sensor->pwdn_gpio, 0); + gpiod_set_value(sensor->reset_gpio, 1); usleep_range(5000, 10000); } @@ -535,7 +535,7 @@ static int ov2680_power_on(struct ov2680_dev *sensor) if (sensor->is_enabled) return 0; - if (!sensor->pwdn_gpio) { + if (!sensor->reset_gpio) { ret = ov2680_write_reg(sensor, OV2680_REG_SOFT_RESET, 0x01); if (ret != 0) { dev_err(dev, "sensor soft reset failed\n"); @@ -990,11 +990,11 @@ static int ov2860_parse_dt(struct ov2680_dev *sensor) struct device *dev = ov2680_to_dev(sensor); int ret; - sensor->pwdn_gpio = devm_gpiod_get_optional(dev, "powerdown", - GPIOD_OUT_HIGH); - ret = PTR_ERR_OR_ZERO(sensor->pwdn_gpio); + sensor->reset_gpio = devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_HIGH); + ret = PTR_ERR_OR_ZERO(sensor->reset_gpio); if (ret < 0) { - dev_dbg(dev, "error while getting powerdown gpio: %d\n", ret); + dev_dbg(dev, "error while getting reset gpio: %d\n", ret); return ret; }