From patchwork Wed May 9 19:03:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10390641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 37B6060353 for ; Wed, 9 May 2018 19:03:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2672D28640 for ; Wed, 9 May 2018 19:03:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B4C628660; Wed, 9 May 2018 19:03:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6905928640 for ; Wed, 9 May 2018 19:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756166AbeEITDl (ORCPT ); Wed, 9 May 2018 15:03:41 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:58824 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbeEITDk (ORCPT ); Wed, 9 May 2018 15:03:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MIUzY8D0ii4rqowUSrnMHpV0vje/Q21gfIWbUE7jZIU=; b=FjMA1yttX3ICaZiKq0fkeBw6I ytwoZU6X1DIC7AM9CCwqrva1K8fZmiBz93rWKqAwtiiGLola1eB0j6Fyvrfr3gm21nQv+0LZfM2es zxml5TmdwrzI2PK8quJxHt1aLZqfEoXXR4ncVVElykppIAlbExTQbOooqnfpk2sJdZ8AxBTkwH+mc bfaA3kcetJyyFjAHuyscFTQfbSfVoIXrwbIjgxsSX7HO8DvG9ZFSPEIWMMqjwbiw8/JEFr4CEHpTh 0tF5eEyHDvDVIPuO8U6HAxWUcaxG+MMCJtWyQQiR3FQaIpWiXjxIQ180W7lf1jShPV29ZDD6SGaBu wR9OF0ixg==; Received: from 177.41.96.165.dynamic.adsl.gvt.net.br ([177.41.96.165] helo=vento.lan) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGUNE-0007xR-98; Wed, 09 May 2018 19:03:36 +0000 Date: Wed, 9 May 2018 16:03:32 -0300 From: Mauro Carvalho Chehab To: Andy Yeh Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, tfiga@chromium.org, jacopo@jmondi.org, Alan Chiang Subject: Re: [RESEND PATCH v9 2/2] media: dw9807: Add dw9807 vcm driver Message-ID: <20180509160332.75c1eb1b@vento.lan> In-Reply-To: <1525276428-17379-3-git-send-email-andy.yeh@intel.com> References: <1525276428-17379-1-git-send-email-andy.yeh@intel.com> <1525276428-17379-3-git-send-email-andy.yeh@intel.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Wed, 2 May 2018 23:53:48 +0800 Andy Yeh escreveu: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides control to set the desired focus. > > Signed-off-by: Andy Yeh > Reviewed-by: Sakari Ailus > Reviewed-by: Tomasz Figa > Reviewed-by: Jacopo Mondi > Acked-by: Rob Herring This adds a new warning. Thanks, Mauro drivers/media/i2c/dw9807.c: In function 'dw9807_set_dac': drivers/media/i2c/dw9807.c:81:16: warning: unused variable 'retry' [-Wunused-variable] int val, ret, retry = 0; ^ Please either fix or fold the following patch. diff --git a/drivers/media/i2c/dw9807.c b/drivers/media/i2c/dw9807.c index 28ede2b47acf..6ebb98717fb1 100644 --- a/drivers/media/i2c/dw9807.c +++ b/drivers/media/i2c/dw9807.c @@ -78,7 +78,7 @@ static int dw9807_set_dac(struct i2c_client *client, u16 data) const char tx_data[3] = { DW9807_MSB_ADDR, ((data >> 8) & 0x03), (data & 0xff) }; - int val, ret, retry = 0; + int val, ret; /* * According to the datasheet, need to check the bus status before we