[v2] dt-bindings: media: rcar_vin: fix style for ports and endpoints

Commit Message

Niklas Söderlund May 28, 2018, 11:17 p.m. UTC

The style for referring to ports and endpoint are wrong. Refer to them
using lowercase and a unit address, port@x and endpoint@x.

Signed-off-by: Niklas Söderlund <[e-mail]>
Reported-by: Geert Uytterhoeven <[e-mail]>
Reviewed-by: Rob Herring <[e-mail]>

---

* Changes since v1.
- Fixed spelling reported by Sergei, s/then/than/.
- Collected Rob's tag.
---
 .../devicetree/bindings/media/rcar_vin.txt    | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Simon Horman May 29, 2018, 8:53 a.m. UTC | #1

On Tue, May 29, 2018 at 01:17:04AM +0200, Niklas Söderlund wrote:
> The style for referring to ports and endpoint are wrong. Refer to them
> using lowercase and a unit address, port@x and endpoint@x.
> 
> Signed-off-by: Niklas Söderlund <[e-mail]>
> Reported-by: Geert Uytterhoeven <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>

Reviewed-by: Simon Horman <[e-mail]>

FWIW, there are some instances of = that aren't preceded by a space
in this file.

This message was brought to you by Whitespace Tuesdays.

Simon Horman May 29, 2018, 1:12 p.m. UTC | #2

On Tue, May 29, 2018 at 01:17:04AM +0200, Niklas Söderlund wrote:
> The style for referring to ports and endpoint are wrong. Refer to them
> using lowercase and a unit address, port@x and endpoint@x.
> 
> Signed-off-by: Niklas Söderlund <[e-mail]>
> Reported-by: Geert Uytterhoeven <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>

Sorry, I responded to v1 before noticing there is a v2:

Reviewed-by: Simon Horman <[e-mail]>

FWIW, there are some instances of = that aren't preceded by a space
in this file.

Patch

diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
index c2c57dcf73f4851b..f8b50f8a3a0bd5d3 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -45,23 +45,23 @@  The per-board settings Gen2 platforms:
 The per-board settings Gen3 platforms:
 
 Gen3 platforms can support both a single connected parallel input source
-from external SoC pins (port0) and/or multiple parallel input sources
-from local SoC CSI-2 receivers (port1) depending on SoC.
+from external SoC pins (port@0) and/or multiple parallel input sources
+from local SoC CSI-2 receivers (port@1) depending on SoC.
 
 - renesas,id - ID number of the VIN, VINx in the documentation.
 - ports
-    - port 0 - sub-node describing a single endpoint connected to the VIN
+    - port@0 - sub-node describing a single endpoint connected to the VIN
       from external SoC pins described in video-interfaces.txt[1].
-      Describing more then one endpoint in port 0 is invalid. Only VIN
-      instances that are connected to external pins should have port 0.
-    - port 1 - sub-nodes describing one or more endpoints connected to
+      Describing more than one endpoint in port@0 is invalid. Only VIN
+      instances that are connected to external pins should have port@0.
+    - port@1 - sub-nodes describing one or more endpoints connected to
       the VIN from local SoC CSI-2 receivers. The endpoint numbers must
       use the following schema.
 
-        - Endpoint 0 - sub-node describing the endpoint connected to CSI20
-        - Endpoint 1 - sub-node describing the endpoint connected to CSI21
-        - Endpoint 2 - sub-node describing the endpoint connected to CSI40
-        - Endpoint 3 - sub-node describing the endpoint connected to CSI41
+        - endpoint@0 - sub-node describing the endpoint connected to CSI20
+        - endpoint@1 - sub-node describing the endpoint connected to CSI21
+        - endpoint@2 - sub-node describing the endpoint connected to CSI40
+        - endpoint@3 - sub-node describing the endpoint connected to CSI41
 
 Device node example for Gen2 platforms
 --------------------------------------