From patchwork Mon Jul 30 09:25:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10548813 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0AFED13B8 for ; Mon, 30 Jul 2018 09:25:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBE4A29A0C for ; Mon, 30 Jul 2018 09:25:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD97229A13; Mon, 30 Jul 2018 09:25:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9642F29A0C for ; Mon, 30 Jul 2018 09:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726854AbeG3K7T (ORCPT ); Mon, 30 Jul 2018 06:59:19 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45927 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbeG3K7S (ORCPT ); Mon, 30 Jul 2018 06:59:18 -0400 Received: by mail-pf1-f193.google.com with SMTP id i26-v6so4265660pfo.12; Mon, 30 Jul 2018 02:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=IzmHTBeBSiVIrmI0rYCsSUBQMd5jnyXOKOPzzJavHxc=; b=BfAWseYaKEvgzC0aHgGnKNJft7AHpn7jESHCTMlZsHJHnDwabh49b4uelgEAQmE1oF vu4QM8gofRSP+un0GuQ4l2VYZ0poix/HMGIdcCu/hZPOklewk24GKRkPGdqSaK5emMhV IvU1MWKOhmjYiLhpMBcjQVSs9A7aohb53cj5fJzuB0057y2W/XkhXijfGdS0WC3NxFlN Mh3ctW/ZjqfA2eBkfsFkviDwmG/XUj+QnMcVJxep3xsI8dtDo/DzYHuljCLjCh+fT1AC PvDcVumJaSmTmMYM9jV+y5l9n+K2ylz/Tni0eXrBNfNVhWcVgYe/QmLBwFrSdsV2i6aw wXqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IzmHTBeBSiVIrmI0rYCsSUBQMd5jnyXOKOPzzJavHxc=; b=FN5UVkIm6i6ATkV8QfSbFzffEgh8yg2VZEvXHZquHPZqMmxFm/myF5J/om0gF6A40o mXIJcLzpNx8K8Cw6CIacN5IYb9M5TguvTk/AWlddXR7KJNCr04Si/A7+573y83sOYxkO BBw9Cnm8soZA6GWK6dJI8CJAl66WAFbx9G/9L2Pt80aDGOyp59bpRS1wct7qyhzT06Ef 05TnODwJKy2T4M77E0QLOCSYjpVEr8In0/uRgeyCmJPaDczF1QGEPBH+ZNJ42+26OYTq d9c0IKgbMIYyGPF9uJ5P2tr9++Pf8nIMLJfdDmnRYWhAL2eBNpr+t0GRIlS4Lr4L8E28 tIpw== X-Gm-Message-State: AOUpUlFDqzDL7MhYvIs+I5Rr5GTvJlinl0Giep3/goFuqLI6oKmwxXBj hfmSjt5fKOGwiMYGjlmVy0A= X-Google-Smtp-Source: AAOMgpd260cQ6HEvevaFmkALXGv6xbf5is7SwBTecNuAcwJKnydd2dBSVZQBEoDZOVoEoH20bJQjQw== X-Received: by 2002:a65:428b:: with SMTP id j11-v6mr15298865pgp.200.1532942713454; Mon, 30 Jul 2018 02:25:13 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:4414:4550:ab75:cee3:d6c1]) by smtp.gmail.com with ESMTPSA id d9-v6sm20096500pfb.86.2018.07.30.02.25.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jul 2018 02:25:13 -0700 (PDT) From: Jia-Ju Bai To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 3/3] media: usb: em28xx: Replace GFP_ATOMIC with GFP_KERNEL in em28xx_init_usb_xfer() Date: Mon, 30 Jul 2018 17:25:07 +0800 Message-Id: <20180730092507.7902-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP em28xx_init_usb_xfer() is never called in atomic context. It calls usb_submit_urb() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/media/usb/em28xx/em28xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c index 36d341fb65dd..4a2ba6132a90 100644 --- a/drivers/media/usb/em28xx/em28xx-core.c +++ b/drivers/media/usb/em28xx/em28xx-core.c @@ -1053,7 +1053,7 @@ int em28xx_init_usb_xfer(struct em28xx *dev, enum em28xx_mode mode, /* submit urbs and enables IRQ */ for (i = 0; i < usb_bufs->num_bufs; i++) { - rc = usb_submit_urb(usb_bufs->urb[i], GFP_ATOMIC); + rc = usb_submit_urb(usb_bufs->urb[i], GFP_KERNEL); if (rc) { dev_err(&dev->intf->dev, "submit of urb %i failed (error=%i)\n", i, rc);