| Message ID | 20180806155025.8912-2-vasilyev@ispras.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] media: davinci: vpif_display: Mix memory leak on probe error path | expand |
Hi, Thanks for the patch. On Mon, Aug 6, 2018 at 4:51 PM Anton Vasilyev <vasilyev@ispras.ru> wrote: > > The patch removes the duplicate platform_data check from vpif_probe(). > > Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available") > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru> > --- > v2: divided the original patch into two and made stylistic fixes based > on the Prabhakar's rewiev. > --- > drivers/media/platform/davinci/vpif_display.c | 5 ----- > 1 file changed, 5 deletions(-) > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Cheers, --Prabhakar Lad
diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c index d9e578ac79c2..f000fc492ef9 100644 --- a/drivers/media/platform/davinci/vpif_display.c +++ b/drivers/media/platform/davinci/vpif_display.c @@ -1255,11 +1255,6 @@ static __init int vpif_probe(struct platform_device *pdev) return -EINVAL; } - if (!pdev->dev.platform_data) { - dev_warn(&pdev->dev, "Missing platform data. Giving up.\n"); - return -EINVAL; - } - vpif_dev = &pdev->dev; err = initialize_vpif();
The patch removes the duplicate platform_data check from vpif_probe(). Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available") Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru> --- v2: divided the original patch into two and made stylistic fixes based on the Prabhakar's rewiev. --- drivers/media/platform/davinci/vpif_display.c | 5 ----- 1 file changed, 5 deletions(-)