diff mbox series

[v2] media: dt-bindings: adv748x: Fix decimal unit addresses

Message ID 20180905132409.14456-1-geert+renesas@glider.be (mailing list archive)
State New, archived
Headers show
Series [v2] media: dt-bindings: adv748x: Fix decimal unit addresses | expand

Commit Message

Geert Uytterhoeven Sept. 5, 2018, 1:24 p.m. UTC
With recent dtc and W=1:

    Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
    Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"

Unit addresses are always hexadecimal (without prefix), while the bases
of reg property values depend on their prefixes.

Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
v2:
  - Add Reviewed-by,
  - Drop RFC state.
---
 Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Sept. 10, 2018, 12:38 p.m. UTC | #1
On Wed, Sep 05, 2018 at 03:24:09PM +0200, Geert Uytterhoeven wrote:
> With recent dtc and W=1:
> 
>     Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
>     Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"
> 
> Unit addresses are always hexadecimal (without prefix), while the bases
> of reg property values depend on their prefixes.
> 
> Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
index 21ffb5ed818302ff..54d1d3bc186949fa 100644
--- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt
+++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
@@ -73,7 +73,7 @@  Example:
 			};
 		};
 
-		port@10 {
+		port@a {
 			reg = <10>;
 
 			adv7482_txa: endpoint {
@@ -83,7 +83,7 @@  Example:
 			};
 		};
 
-		port@11 {
+		port@b {
 			reg = <11>;
 
 			adv7482_txb: endpoint {