| Message ID | 20180911065921.23818-2-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/10] udmabuf: sort headers, drop uapi/ path prefix | expand |
Hi Gerd, Thank you for the patch. On Tuesday, 11 September 2018 09:59:12 EEST Gerd Hoffmann wrote: > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/dma-buf/udmabuf.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index 2e8502250a..e63d301bcb 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -1,17 +1,16 @@ > // SPDX-License-Identifier: GPL-2.0 > -#include <linux/init.h> > -#include <linux/module.h> > +#include <linux/cred.h> > #include <linux/device.h> > -#include <linux/kernel.h> > -#include <linux/slab.h> > -#include <linux/miscdevice.h> > #include <linux/dma-buf.h> > #include <linux/highmem.h> > -#include <linux/cred.h> > -#include <linux/shmem_fs.h> > +#include <linux/init.h> > +#include <linux/kernel.h> > #include <linux/memfd.h> > - > -#include <uapi/linux/udmabuf.h> > +#include <linux/miscdevice.h> > +#include <linux/module.h> > +#include <linux/slab.h> > +#include <linux/shmem_fs.h> Nearly there, l comes after h :-) Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > +#include <linux/udmabuf.h> > > struct udmabuf { > u32 pagecount;
diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index 2e8502250a..e63d301bcb 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -1,17 +1,16 @@ // SPDX-License-Identifier: GPL-2.0 -#include <linux/init.h> -#include <linux/module.h> +#include <linux/cred.h> #include <linux/device.h> -#include <linux/kernel.h> -#include <linux/slab.h> -#include <linux/miscdevice.h> #include <linux/dma-buf.h> #include <linux/highmem.h> -#include <linux/cred.h> -#include <linux/shmem_fs.h> +#include <linux/init.h> +#include <linux/kernel.h> #include <linux/memfd.h> - -#include <uapi/linux/udmabuf.h> +#include <linux/miscdevice.h> +#include <linux/module.h> +#include <linux/slab.h> +#include <linux/shmem_fs.h> +#include <linux/udmabuf.h> struct udmabuf { u32 pagecount;
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- drivers/dma-buf/udmabuf.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)