diff mbox series

media: imx: use well defined 32-bit RGB pixel format

Message ID 20180918094231.20815-1-p.zabel@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series media: imx: use well defined 32-bit RGB pixel format | expand

Commit Message

Philipp Zabel Sept. 18, 2018, 9:42 a.m. UTC
The documentation in Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst
tells us that the V4L2_PIX_FMT_RGB32 format is deprecated and must not
be used by new drivers. Replace it with V4L2_PIX_FMT_XRGB32.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/staging/media/imx/imx-media-utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Steve Longerbeam Sept. 18, 2018, 4:58 p.m. UTC | #1
On 09/18/2018 02:42 AM, Philipp Zabel wrote:
> The documentation in Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst
> tells us that the V4L2_PIX_FMT_RGB32 format is deprecated and must not
> be used by new drivers. Replace it with V4L2_PIX_FMT_XRGB32.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Acked-by: Steve Longerbeam <steve_longerbeam@mentor.com>

> ---
>   drivers/staging/media/imx/imx-media-utils.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index 8aa13403b09d..0eaa353d5cb3 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -88,7 +88,7 @@ static const struct imx_media_pixfmt rgb_formats[] = {
>   		.cs     = IPUV3_COLORSPACE_RGB,
>   		.bpp    = 24,
>   	}, {
> -		.fourcc	= V4L2_PIX_FMT_RGB32,
> +		.fourcc	= V4L2_PIX_FMT_XRGB32,
>   		.codes  = {MEDIA_BUS_FMT_ARGB8888_1X32},
>   		.cs     = IPUV3_COLORSPACE_RGB,
>   		.bpp    = 32,
> @@ -212,7 +212,7 @@ static const struct imx_media_pixfmt ipu_yuv_formats[] = {
>   
>   static const struct imx_media_pixfmt ipu_rgb_formats[] = {
>   	{
> -		.fourcc	= V4L2_PIX_FMT_RGB32,
> +		.fourcc	= V4L2_PIX_FMT_XRGB32,
>   		.codes  = {MEDIA_BUS_FMT_ARGB8888_1X32},
>   		.cs     = IPUV3_COLORSPACE_RGB,
>   		.bpp    = 32,
diff mbox series

Patch

diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
index 8aa13403b09d..0eaa353d5cb3 100644
--- a/drivers/staging/media/imx/imx-media-utils.c
+++ b/drivers/staging/media/imx/imx-media-utils.c
@@ -88,7 +88,7 @@  static const struct imx_media_pixfmt rgb_formats[] = {
 		.cs     = IPUV3_COLORSPACE_RGB,
 		.bpp    = 24,
 	}, {
-		.fourcc	= V4L2_PIX_FMT_RGB32,
+		.fourcc	= V4L2_PIX_FMT_XRGB32,
 		.codes  = {MEDIA_BUS_FMT_ARGB8888_1X32},
 		.cs     = IPUV3_COLORSPACE_RGB,
 		.bpp    = 32,
@@ -212,7 +212,7 @@  static const struct imx_media_pixfmt ipu_yuv_formats[] = {
 
 static const struct imx_media_pixfmt ipu_rgb_formats[] = {
 	{
-		.fourcc	= V4L2_PIX_FMT_RGB32,
+		.fourcc	= V4L2_PIX_FMT_XRGB32,
 		.codes  = {MEDIA_BUS_FMT_ARGB8888_1X32},
 		.cs     = IPUV3_COLORSPACE_RGB,
 		.bpp    = 32,