| Message ID | 20180926061242.8130-1-ricardo.ribalda@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: smiapp: Remove unused loop | expand |
Hi Ricardo, On Wed, Sep 26, 2018 at 08:12:42AM +0200, Ricardo Ribalda Delgado wrote: > The loop seemed to be made to calculate max, but max is not used in that > function. > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> The code has been left there probably when the valid link frequency calculation was changed. Thanks! > --- > drivers/media/i2c/smiapp/smiapp-core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c > index 99f3b295ae3c..bccbf4c841d6 100644 > --- a/drivers/media/i2c/smiapp/smiapp-core.c > +++ b/drivers/media/i2c/smiapp/smiapp-core.c > @@ -624,7 +624,7 @@ static int smiapp_init_late_controls(struct smiapp_sensor *sensor) > { > unsigned long *valid_link_freqs = &sensor->valid_link_freqs[ > sensor->csi_format->compressed - sensor->compressed_min_bpp]; > - unsigned int max, i; > + unsigned int i; > > for (i = 0; i < ARRAY_SIZE(sensor->test_data); i++) { > int max_value = (1 << sensor->csi_format->width) - 1; > @@ -635,8 +635,6 @@ static int smiapp_init_late_controls(struct smiapp_sensor *sensor) > 0, max_value, 1, max_value); > } > > - for (max = 0; sensor->hwcfg->op_sys_clock[max + 1]; max++); > - > sensor->link_freq = v4l2_ctrl_new_int_menu( > &sensor->src->ctrl_handler, &smiapp_ctrl_ops, > V4L2_CID_LINK_FREQ, __fls(*valid_link_freqs), > -- > 2.19.0 >
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c index 99f3b295ae3c..bccbf4c841d6 100644 --- a/drivers/media/i2c/smiapp/smiapp-core.c +++ b/drivers/media/i2c/smiapp/smiapp-core.c @@ -624,7 +624,7 @@ static int smiapp_init_late_controls(struct smiapp_sensor *sensor) { unsigned long *valid_link_freqs = &sensor->valid_link_freqs[ sensor->csi_format->compressed - sensor->compressed_min_bpp]; - unsigned int max, i; + unsigned int i; for (i = 0; i < ARRAY_SIZE(sensor->test_data); i++) { int max_value = (1 << sensor->csi_format->width) - 1; @@ -635,8 +635,6 @@ static int smiapp_init_late_controls(struct smiapp_sensor *sensor) 0, max_value, 1, max_value); } - for (max = 0; sensor->hwcfg->op_sys_clock[max + 1]; max++); - sensor->link_freq = v4l2_ctrl_new_int_menu( &sensor->src->ctrl_handler, &smiapp_ctrl_ops, V4L2_CID_LINK_FREQ, __fls(*valid_link_freqs),
The loop seemed to be made to calculate max, but max is not used in that function. Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- drivers/media/i2c/smiapp/smiapp-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)