| Message ID | 20180926080937.19501-2-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Unlocked v4l2_ctrl_grab | expand |
On 09/26/2018 10:09 AM, Sakari Ailus wrote: > v4l2_ctrl_grab() is documented in the header; there's no need to have a > comment explaining what the function does in the .c file. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Regards, Hans > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c > index ee006d34c19f..ab393adf51eb 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -2511,12 +2511,6 @@ void v4l2_ctrl_activate(struct v4l2_ctrl *ctrl, bool active) > } > EXPORT_SYMBOL(v4l2_ctrl_activate); > > -/* Grab/ungrab a control. > - Typically used when streaming starts and you want to grab controls, > - preventing the user from changing them. > - > - Just call this and the framework will block any attempts to change > - these controls. */ > void v4l2_ctrl_grab(struct v4l2_ctrl *ctrl, bool grabbed) > { > bool old; >
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index ee006d34c19f..ab393adf51eb 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -2511,12 +2511,6 @@ void v4l2_ctrl_activate(struct v4l2_ctrl *ctrl, bool active) } EXPORT_SYMBOL(v4l2_ctrl_activate); -/* Grab/ungrab a control. - Typically used when streaming starts and you want to grab controls, - preventing the user from changing them. - - Just call this and the framework will block any attempts to change - these controls. */ void v4l2_ctrl_grab(struct v4l2_ctrl *ctrl, bool grabbed) { bool old;
v4l2_ctrl_grab() is documented in the header; there's no need to have a comment explaining what the function does in the .c file. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/v4l2-core/v4l2-ctrls.c | 6 ------ 1 file changed, 6 deletions(-)