| Message ID | 20180928073213.10022-1-andrea.merello@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [media] v4l: xilinx: fix typo in formats table | expand |
Hi Andrea, Thank you for the patch. On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: > In formats table the entry for CFA pattern "rggb" has GRBG fourcc. > This patch fixes it. > > Cc: linux-media@vger.kernel.org > Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it> > Signed-off-by: Andrea Merello <andrea.merello@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Michal, should I take the patch in my tree ? > --- > drivers/media/platform/xilinx/xilinx-vip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/xilinx/xilinx-vip.c > b/drivers/media/platform/xilinx/xilinx-vip.c index > 311259129504..e9567cdfb89b 100644 > --- a/drivers/media/platform/xilinx/xilinx-vip.c > +++ b/drivers/media/platform/xilinx/xilinx-vip.c > @@ -36,7 +36,7 @@ static const struct xvip_video_format xvip_video_formats[] > = { { XVIP_VF_MONO_SENSOR, 8, "mono", MEDIA_BUS_FMT_Y8_1X8, > 1, V4L2_PIX_FMT_GREY, "Greyscale 8-bit" }, > { XVIP_VF_MONO_SENSOR, 8, "rggb", MEDIA_BUS_FMT_SRGGB8_1X8, > - 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit RGGB" }, > + 1, V4L2_PIX_FMT_SRGGB8, "Bayer 8-bit RGGB" }, > { XVIP_VF_MONO_SENSOR, 8, "grbg", MEDIA_BUS_FMT_SGRBG8_1X8, > 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit GRBG" }, > { XVIP_VF_MONO_SENSOR, 8, "gbrg", MEDIA_BUS_FMT_SGBRG8_1X8,
Hi Laurent, On 28.9.2018 14:52, Laurent Pinchart wrote: > Hi Andrea, > > Thank you for the patch. > > On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: >> In formats table the entry for CFA pattern "rggb" has GRBG fourcc. >> This patch fixes it. >> >> Cc: linux-media@vger.kernel.org >> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it> >> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Michal, should I take the patch in my tree ? definitely. I am not collecting patches for media tree. Thanks, Michal
Hi Michal, On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote: > On 28.9.2018 14:52, Laurent Pinchart wrote: > > On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: > >> In formats table the entry for CFA pattern "rggb" has GRBG fourcc. > >> This patch fixes it. > >> > >> Cc: linux-media@vger.kernel.org > >> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it> > >> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Michal, should I take the patch in my tree ? > > definitely. I am not collecting patches for media tree. Taken in my tree. By the way, have we reached any conclusion regarding https://lkml.org/lkml/ 2017/12/18/112 ?
Hi Laurent, On 1.10.2018 15:26, Laurent Pinchart wrote: > Hi Michal, > > On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote: >> On 28.9.2018 14:52, Laurent Pinchart wrote: >>> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: >>>> In formats table the entry for CFA pattern "rggb" has GRBG fourcc. >>>> This patch fixes it. >>>> >>>> Cc: linux-media@vger.kernel.org >>>> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it> >>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> >>> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> >>> Michal, should I take the patch in my tree ? >> >> definitely. I am not collecting patches for media tree. > > Taken in my tree. > > By the way, have we reached any conclusion regarding https://lkml.org/lkml/ > 2017/12/18/112 ? Xilinx has started to use SPDX without any issue. It means conversion should be fine to do. Thanks, Michal
Hi Michal, On Monday, 1 October 2018 16:28:32 EEST Michal Simek wrote: > On 1.10.2018 15:26, Laurent Pinchart wrote: > > On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote: > >> On 28.9.2018 14:52, Laurent Pinchart wrote: > >>> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: > >>>> In formats table the entry for CFA pattern "rggb" has GRBG fourcc. > >>>> This patch fixes it. > >>>> > >>>> Cc: linux-media@vger.kernel.org > >>>> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it> > >>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> > >>> > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>> > >>> Michal, should I take the patch in my tree ? > >> > >> definitely. I am not collecting patches for media tree. > > > > Taken in my tree. > > > > By the way, have we reached any conclusion regarding > > https://lkml.org/lkml/ > > 2017/12/18/112 ? > > Xilinx has started to use SPDX without any issue. It means conversion > should be fine to do. That's good to know, I'll resubmit the patch then, and CC you to get an ack.
On 1.10.2018 15:36, Laurent Pinchart wrote: > Hi Michal, > > On Monday, 1 October 2018 16:28:32 EEST Michal Simek wrote: >> On 1.10.2018 15:26, Laurent Pinchart wrote: >>> On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote: >>>> On 28.9.2018 14:52, Laurent Pinchart wrote: >>>>> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: >>>>>> In formats table the entry for CFA pattern "rggb" has GRBG fourcc. >>>>>> This patch fixes it. >>>>>> >>>>>> Cc: linux-media@vger.kernel.org >>>>>> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it> >>>>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> >>>>> >>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>>>> >>>>> Michal, should I take the patch in my tree ? >>>> >>>> definitely. I am not collecting patches for media tree. >>> >>> Taken in my tree. >>> >>> By the way, have we reached any conclusion regarding >>> https://lkml.org/lkml/ >>> 2017/12/18/112 ? >> >> Xilinx has started to use SPDX without any issue. It means conversion >> should be fine to do. > > That's good to know, I'll resubmit the patch then, and CC you to get an ack. > Sure go ahead. M
diff --git a/drivers/media/platform/xilinx/xilinx-vip.c b/drivers/media/platform/xilinx/xilinx-vip.c index 311259129504..e9567cdfb89b 100644 --- a/drivers/media/platform/xilinx/xilinx-vip.c +++ b/drivers/media/platform/xilinx/xilinx-vip.c @@ -36,7 +36,7 @@ static const struct xvip_video_format xvip_video_formats[] = { { XVIP_VF_MONO_SENSOR, 8, "mono", MEDIA_BUS_FMT_Y8_1X8, 1, V4L2_PIX_FMT_GREY, "Greyscale 8-bit" }, { XVIP_VF_MONO_SENSOR, 8, "rggb", MEDIA_BUS_FMT_SRGGB8_1X8, - 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit RGGB" }, + 1, V4L2_PIX_FMT_SRGGB8, "Bayer 8-bit RGGB" }, { XVIP_VF_MONO_SENSOR, 8, "grbg", MEDIA_BUS_FMT_SGRBG8_1X8, 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit GRBG" }, { XVIP_VF_MONO_SENSOR, 8, "gbrg", MEDIA_BUS_FMT_SGBRG8_1X8,