| Message ID | 20181009234245.25830-1-rajmohan.mani@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: intel-ipu3: cio2: Remove redundant definitions | expand |
Hi Rajmohan Thank you for the patch, On 10/10/18 00:42, Rajmohan Mani wrote: > Removed redundant CIO2_IMAGE_MAX_* definitions > > Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") > > Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Looks like this {sh,c}ould be bundled in with "[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration. -- Regards Kieran Bingham > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h > index 240635be7a31..7caab9b8c2b9 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h > @@ -10,8 +10,6 @@ > #define CIO2_PCI_ID 0x9d32 > #define CIO2_PCI_BAR 0 > #define CIO2_DMA_MASK DMA_BIT_MASK(39) > -#define CIO2_IMAGE_MAX_WIDTH 4224 > -#define CIO2_IMAGE_MAX_LENGTH 3136 > > #define CIO2_IMAGE_MAX_WIDTH 4224 > #define CIO2_IMAGE_MAX_LENGTH 3136 >
On 10/11/2018 05:33 PM, Kieran Bingham wrote: > Hi Rajmohan > > Thank you for the patch, > > On 10/10/18 00:42, Rajmohan Mani wrote: >> Removed redundant CIO2_IMAGE_MAX_* definitions >> >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") >> >> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com> > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Looks like this {sh,c}ould be bundled in with > "[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration. Raj and Sakari, I think this change could be bundled into the Trivial patch sets, what do you think? > > -- > Regards > > Kieran Bingham > >> --- >> drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h >> index 240635be7a31..7caab9b8c2b9 100644 >> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h >> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h >> @@ -10,8 +10,6 @@ >> #define CIO2_PCI_ID 0x9d32 >> #define CIO2_PCI_BAR 0 >> #define CIO2_DMA_MASK DMA_BIT_MASK(39) >> -#define CIO2_IMAGE_MAX_WIDTH 4224 >> -#define CIO2_IMAGE_MAX_LENGTH 3136 >> >> #define CIO2_IMAGE_MAX_WIDTH 4224 >> #define CIO2_IMAGE_MAX_LENGTH 3136 >> >
Hi Bingbu, Kieren, > Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions > > > > On 10/11/2018 05:33 PM, Kieran Bingham wrote: > > Hi Rajmohan > > > > Thank you for the patch, > > > > On 10/10/18 00:42, Rajmohan Mani wrote: > >> Removed redundant CIO2_IMAGE_MAX_* definitions > >> > >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 > >> driver") > >> > >> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com> > > Reviewed-by: Kieran Bingham > <kieran.bingham+renesas@ideasonboard.com> > > > > Looks like this {sh,c}ould be bundled in with "[PATCH 0/2] Trivial > > CIO2 patches" from Sakari at integration. > Raj and Sakari, I think this change could be bundled into the Trivial patch sets, > what do you think? > > Sounds good to me. I will leave this up to Sakari. Thanks Raj
On Fri, Oct 12, 2018 at 07:00:44PM +0000, Mani, Rajmohan wrote: > Hi Bingbu, Kieren, > > > Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions > > > > > > > > On 10/11/2018 05:33 PM, Kieran Bingham wrote: > > > Hi Rajmohan > > > > > > Thank you for the patch, > > > > > > On 10/10/18 00:42, Rajmohan Mani wrote: > > >> Removed redundant CIO2_IMAGE_MAX_* definitions > > >> > > >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 > > >> driver") > > >> > > >> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com> > > > Reviewed-by: Kieran Bingham > > <kieran.bingham+renesas@ideasonboard.com> > > > > > > Looks like this {sh,c}ould be bundled in with "[PATCH 0/2] Trivial > > > CIO2 patches" from Sakari at integration. > > Raj and Sakari, I think this change could be bundled into the Trivial patch sets, > > what do you think? > > > > > Sounds good to me. > I will leave this up to Sakari. Yes, these are all in my branch for 4.21.
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h index 240635be7a31..7caab9b8c2b9 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h @@ -10,8 +10,6 @@ #define CIO2_PCI_ID 0x9d32 #define CIO2_PCI_BAR 0 #define CIO2_DMA_MASK DMA_BIT_MASK(39) -#define CIO2_IMAGE_MAX_WIDTH 4224 -#define CIO2_IMAGE_MAX_LENGTH 3136 #define CIO2_IMAGE_MAX_WIDTH 4224 #define CIO2_IMAGE_MAX_LENGTH 3136
Removed redundant CIO2_IMAGE_MAX_* definitions Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com> --- drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 -- 1 file changed, 2 deletions(-)