| Message ID | 20181101233144.31507-15-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | v4l: add support for multiplexed streams | expand |
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:28AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus <sakari.ailus@linux.intel.com> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/media-entity.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index a5bb257d5a68f755..42977634d7102852 100644 > --- a/drivers/media/media-entity.c > +++ b/drivers/media/media-entity.c > @@ -360,6 +360,9 @@ static void media_graph_walk_iter(struct media_graph *graph) > */ > if (!media_entity_has_route(pad->entity, pad->index, local->index)) { > link_top(graph) = link_top(graph)->next; > + dev_dbg(pad->graph_obj.mdev->dev, > + "walk: skipping \"%s\":%u -> %u (no route)\n", > + pad->entity->name, pad->index, local->index); Maybe "%s: skipping...", __func__, ? Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > return; > } >
On Wed, Jan 16, 2019 at 01:35:14AM +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Fri, Nov 02, 2018 at 12:31:28AM +0100, Niklas Söderlund wrote: > > From: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > > drivers/media/media-entity.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > > index a5bb257d5a68f755..42977634d7102852 100644 > > --- a/drivers/media/media-entity.c > > +++ b/drivers/media/media-entity.c > > @@ -360,6 +360,9 @@ static void media_graph_walk_iter(struct media_graph *graph) > > */ > > if (!media_entity_has_route(pad->entity, pad->index, local->index)) { > > link_top(graph) = link_top(graph)->next; > > + dev_dbg(pad->graph_obj.mdev->dev, > > + "walk: skipping \"%s\":%u -> %u (no route)\n", > > + pad->entity->name, pad->index, local->index); > > Maybe "%s: skipping...", __func__, ? We already have a similar format elsewhere for messages alike. I'd add the function name to all of them rather than just this one. The message is also informative and unique enough to be easily found. > > Apart from that, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > return; > > } > > > > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index a5bb257d5a68f755..42977634d7102852 100644 --- a/drivers/media/media-entity.c +++ b/drivers/media/media-entity.c @@ -360,6 +360,9 @@ static void media_graph_walk_iter(struct media_graph *graph) */ if (!media_entity_has_route(pad->entity, pad->index, local->index)) { link_top(graph) = link_top(graph)->next; + dev_dbg(pad->graph_obj.mdev->dev, + "walk: skipping \"%s\":%u -> %u (no route)\n", + pad->entity->name, pad->index, local->index); return; }