From patchwork Mon Nov 19 15:17:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 10688769 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C88413BB for ; Mon, 19 Nov 2018 15:17:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B62A29E29 for ; Mon, 19 Nov 2018 15:17:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E02A29F19; Mon, 19 Nov 2018 15:17:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3700829E29 for ; Mon, 19 Nov 2018 15:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729662AbeKTBls (ORCPT ); Mon, 19 Nov 2018 20:41:48 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36726 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729587AbeKTBls (ORCPT ); Mon, 19 Nov 2018 20:41:48 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id DF62F263B43 From: Ezequiel Garcia To: linux-media@vger.kernel.org Cc: Hans Verkuil , Ezequiel Garcia Subject: [PATCH] v4l2-compliance: Remove spurious error messages Date: Mon, 19 Nov 2018 12:17:43 -0300 Message-Id: <20181119151743.27275-1-ezequiel@collabora.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Get rid of a couple confusing error messages, namely: test VIDIOC_G_FMT: OK fail: v4l2-test-formats.cpp(464): pix_mp.plane_fmt[0].reserved not zeroed fail: v4l2-test-formats.cpp(752): Video Output Multiplanar is valid, but TRY_FMT failed to return a format test VIDIOC_TRY_FMT: FAIL fail: v4l2-test-formats.cpp(464): pix_mp.plane_fmt[0].reserved not zeroed fail: v4l2-test-formats.cpp(1017): Video Output Multiplanar is valid, but no S_FMT was implemented test VIDIOC_S_FMT: FAI Where only the first message "pix_mp.plane_fmt[0].reserved not zeroed" is accurate. Signed-off-by: Ezequiel Garcia --- utils/v4l2-compliance/v4l2-test-formats.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp index 2fb811ad5eb4..006cc3222c65 100644 --- a/utils/v4l2-compliance/v4l2-test-formats.cpp +++ b/utils/v4l2-compliance/v4l2-test-formats.cpp @@ -748,8 +748,7 @@ int testTryFormats(struct node *node) } ret = testFormatsType(node, ret, type, fmt, true); if (ret) - return fail("%s is valid, but TRY_FMT failed to return a format\n", - buftype2s(type).c_str()); + return ret; } memset(&fmt, 0, sizeof(fmt)); @@ -1013,8 +1012,7 @@ int testSetFormats(struct node *node) } ret = testFormatsType(node, ret, type, fmt_set, true); if (ret) - return fail("%s is valid, but no S_FMT was implemented\n", - buftype2s(type).c_str()); + return ret; fmt_set = fmt; ret = doioctl(node, VIDIOC_S_FMT, &fmt_set);