| Message ID | 20190118085206.2598-4-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: ov5640: JPEG and test pattern improvements | expand |
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 22d07b3cc8a2..a1fd69a21df1 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -2461,8 +2461,7 @@ static const char * const test_pattern_menu[] = { static const u8 test_pattern_val[] = { 0, - OV5640_TEST_ENABLE | OV5640_TEST_TRANSPARENT | - OV5640_TEST_BAR_VERT_CHANGE_1 | + OV5640_TEST_ENABLE | OV5640_TEST_BAR_VERT_CHANGE_1 | OV5640_TEST_BAR, };
The transparent feature for test patterns blends the test pattern with an actual captured image. This makes the result non-static, subject to changes in the sensor's field of view. Test patterns should be predictable and deterministic, even if they are dynamic patterns. Disable the transparent feature of the test pattern. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- drivers/media/i2c/ov5640.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)