From patchwork Sun Feb 24 09:02:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dafna Hirschfeld X-Patchwork-Id: 10827771 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6447A6C2 for ; Sun, 24 Feb 2019 09:02:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 519082BA9F for ; Sun, 24 Feb 2019 09:02:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 465852BAA5; Sun, 24 Feb 2019 09:02:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D28732BAA0 for ; Sun, 24 Feb 2019 09:02:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728004AbfBXJCx (ORCPT ); Sun, 24 Feb 2019 04:02:53 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44126 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfBXJCx (ORCPT ); Sun, 24 Feb 2019 04:02:53 -0500 Received: by mail-wr1-f66.google.com with SMTP id w2so6640390wrt.11 for ; Sun, 24 Feb 2019 01:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MAunhPLiQsMAY05okqvSKPPo8Hd0S9bQIXD1NW17kLg=; b=t+pAJrRLyj+1flja8Y5dsBFxU8EQ7so3MUO5Hw75U7Fo0HLLOopLeEfVghtNWMGWZ8 bZX6hubYQHrgX+SMPZzGG7wyQaeINaKjgwu4lVlJMCI/+0Nbjt0qcOOtzzh7zpKzpN7N xzNSDZrvHHmUNzajORY6NXTrzK+2GAaq1GTuwu1Z8rbS1MPqJ/TJcz6xLPKA3jx7gvHB Il+1b/Wjx9v2RDVNJtqPs6zTE6KHv5/69gXNvol8NvpMPj2wnHmtS+a9bsBDKuSb3+Nc L6SE0ZHujTKPWJwgTXF5Ew5lRttcM7JgzvlgEV9Ok5d1XMQOMVVX3B7v5YgtwLkqNsrU 9mWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MAunhPLiQsMAY05okqvSKPPo8Hd0S9bQIXD1NW17kLg=; b=iJOmUY973DWwGlwysPB65Zyah+3mwALlXswcgIPqtxvSZ68QaL+FH2qIt02udA8pzc QcV1yg/V+RO/6glfIwMczym/Iyi3CZWLe2ex+Dj0EI7yYs6NZC05UnnmcmRnrSlDkfMV QETrGcTknTyyFkQbGf9mKuSWHO1xMWZJLmMZraOseORONbTEjOYXzeSW+byVURFFMgL2 lsmBSMdWyay4ZpCbBwx7gyDOu5dQe3WUQwowEKy79EBiJbptOcbf34W6BrLIAiD+6/f8 Ic0VEEF2ktN2xPKcIc3JBzmZmq+9KLIXoAmSo77Z+F//JcnG2UPyF7ZIZ9Lum8RSta2L 44GA== X-Gm-Message-State: AHQUAuYc4IC5jNY9MoWYenEt5sHQhrGbieL6HkeA7wJcVHqtuHlRqpzN pGnZ7G4Qb2H2ySIQdw3jrIxg7DanY8I= X-Google-Smtp-Source: AHgI3IaSJHD4jrfUEvOT4y0jpw1qy+6J/o5CDyvANvTJaInXsWeMbiscAD7otuSVzDEnWP5G1drMhw== X-Received: by 2002:adf:a4c9:: with SMTP id h9mr8541132wrb.254.1550998971063; Sun, 24 Feb 2019 01:02:51 -0800 (PST) Received: from ubuntu.home ([77.127.107.32]) by smtp.gmail.com with ESMTPSA id e75sm8701971wmg.32.2019.02.24.01.02.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Feb 2019 01:02:50 -0800 (PST) From: Dafna Hirschfeld To: linux-media@vger.kernel.org Cc: hverkuil@xs4all.nl, helen.koike@collabora.com, Hans Verkuil Subject: [PATCH v3 01/18] vb2: add requires_requests bit for stateless codecs Date: Sun, 24 Feb 2019 01:02:18 -0800 Message-Id: <20190224090234.19723-2-dafna3@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190224090234.19723-1-dafna3@gmail.com> References: <20190224090234.19723-1-dafna3@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Hans Verkuil Stateless codecs require the use of the Request API as opposed of it being optional. So add a bit to indicate this and let vb2 check for this. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-core.c | 5 ++++- drivers/media/common/videobuf2/videobuf2-v4l2.c | 6 ++++++ include/media/videobuf2-core.h | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c index 15b6b9c0a2e4..d8cf9d3ec54d 100644 --- a/drivers/media/common/videobuf2/videobuf2-core.c +++ b/drivers/media/common/videobuf2/videobuf2-core.c @@ -1518,7 +1518,7 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb, if ((req && q->uses_qbuf) || (!req && vb->state != VB2_BUF_STATE_IN_REQUEST && - q->uses_requests)) { + (q->uses_requests || q->requires_requests))) { dprintk(1, "queue in wrong mode (qbuf vs requests)\n"); return -EBUSY; } @@ -2247,6 +2247,9 @@ int vb2_core_queue_init(struct vb2_queue *q) WARN_ON(!q->ops->buf_queue)) return -EINVAL; + if (WARN_ON(q->requires_requests && !q->supports_requests)) + return -EINVAL; + INIT_LIST_HEAD(&q->queued_list); INIT_LIST_HEAD(&q->done_list); spin_lock_init(&q->done_lock); diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c index d09dee20e421..4dc4855056f1 100644 --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c @@ -385,6 +385,10 @@ static int vb2_queue_or_prepare_buf(struct vb2_queue *q, struct media_device *md dprintk(1, "%s: queue uses requests\n", opname); return -EBUSY; } + if (q->requires_requests) { + dprintk(1, "%s: queue requires requests\n", opname); + return -EACCES; + } return 0; } else if (!q->supports_requests) { dprintk(1, "%s: queue does not support requests\n", opname); @@ -658,6 +662,8 @@ static void fill_buf_caps(struct vb2_queue *q, u32 *caps) #ifdef CONFIG_MEDIA_CONTROLLER_REQUEST_API if (q->supports_requests) *caps |= V4L2_BUF_CAP_SUPPORTS_REQUESTS; + if (q->requires_requests) + *caps |= V4L2_BUF_CAP_REQUIRES_REQUESTS; #endif } diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index a844abcae71e..bf50090af859 100644 --- a/include/media/videobuf2-core.h +++ b/include/media/videobuf2-core.h @@ -484,6 +484,8 @@ struct vb2_buf_ops { * has not been called. This is a vb1 idiom that has been adopted * also by vb2. * @supports_requests: this queue supports the Request API. + * @requires_requests: this queue requires the Request API. If this is set to 1, + * then supports_requests must be set to 1 as well. * @uses_qbuf: qbuf was used directly for this queue. Set to 1 the first * time this is called. Set to 0 when the queue is canceled. * If this is 1, then you cannot queue buffers from a request. @@ -558,6 +560,7 @@ struct vb2_queue { unsigned allow_zero_bytesused:1; unsigned quirk_poll_must_check_waiting_for_buffers:1; unsigned supports_requests:1; + unsigned requires_requests:1; unsigned uses_qbuf:1; unsigned uses_requests:1;