diff mbox series

[v3,1/2] dt-bindings: rcar-csi2: List resets as a mandatory property

Message ID 20190312234930.23193-2-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State New, archived
Headers show
Series rcar-csi2: Use standby mode instead of resetting | expand

Commit Message

Niklas Söderlund March 12, 2019, 11:49 p.m. UTC
The resets property will become mandatory to operate the device, list it
as such. All device tree source files have always included the reset
property so making it mandatory will not introduce any regressions.

While at it improve the description for the clocks property.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jacopo Mondi April 12, 2019, 7:03 a.m. UTC | #1
Hi Niklas,

On Wed, Mar 13, 2019 at 12:49:29AM +0100, Niklas Söderlund wrote:
> The resets property will become mandatory to operate the device, list it
> as such. All device tree source files have always included the reset
> property so making it mandatory will not introduce any regressions.
>
> While at it improve the description for the clocks property.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> index d63275e17afdd180..9a0d0531c67df48c 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -18,7 +18,8 @@ Mandatory properties
>
>   - reg: the register base and size for the device registers
>   - interrupts: the interrupt for the device
> - - clocks: reference to the parent clock
> + - clocks: A phandle + clock specifier for the module clock
> + - resets: A phandle + reset specifier for the module reset
>

Verified that all users in mainline of this bindings already contains
a 'reset' property:
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j

>  The device node shall contain two 'port' child nodes according to the
>  bindings defined in Documentation/devicetree/bindings/media/
> --
> 2.21.0
>
Jacopo Mondi April 12, 2019, 7:07 a.m. UTC | #2
Oh, I missed a pull request was sent already for this series :)

Even better!

On Fri, Apr 12, 2019 at 09:03:38AM +0200, Jacopo Mondi wrote:
> Hi Niklas,
>
> On Wed, Mar 13, 2019 at 12:49:29AM +0100, Niklas Söderlund wrote:
> > The resets property will become mandatory to operate the device, list it
> > as such. All device tree source files have always included the reset
> > property so making it mandatory will not introduce any regressions.
> >
> > While at it improve the description for the clocks property.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > index d63275e17afdd180..9a0d0531c67df48c 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > @@ -18,7 +18,8 @@ Mandatory properties
> >
> >   - reg: the register base and size for the device registers
> >   - interrupts: the interrupt for the device
> > - - clocks: reference to the parent clock
> > + - clocks: A phandle + clock specifier for the module clock
> > + - resets: A phandle + reset specifier for the module reset
> >
>
> Verified that all users in mainline of this bindings already contains
> a 'reset' property:
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Thanks
>    j
>
> >  The device node shall contain two 'port' child nodes according to the
> >  bindings defined in Documentation/devicetree/bindings/media/
> > --
> > 2.21.0
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
index d63275e17afdd180..9a0d0531c67df48c 100644
--- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
+++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
@@ -18,7 +18,8 @@  Mandatory properties
 
  - reg: the register base and size for the device registers
  - interrupts: the interrupt for the device
- - clocks: reference to the parent clock
+ - clocks: A phandle + clock specifier for the module clock
+ - resets: A phandle + reset specifier for the module reset
 
 The device node shall contain two 'port' child nodes according to the
 bindings defined in Documentation/devicetree/bindings/media/