| Message ID | 20190411161256.19607-4-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: vsp1: Phased partition overlap support | expand |
Hi Kieran, Thank you for the patch. On Thu, Apr 11, 2019 at 05:12:54PM +0100, Kieran Bingham wrote: > The image partition algorithm operates on the image dimensions as input > into the WPF entity. Document this in the code block header. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_video.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c > index 563f9a02c373..d1ecc3d91290 100644 > --- a/drivers/media/platform/vsp1/vsp1_video.c > +++ b/drivers/media/platform/vsp1/vsp1_video.c > @@ -173,6 +173,14 @@ static int __vsp1_video_try_format(struct vsp1_video *video, > > /* ----------------------------------------------------------------------------- > * VSP1 Partition Algorithm support > + * > + * VSP hardware can have restrictions on image width dependent on the hardware Did you mean s/dependent/depending/ ? > + * configuration of the pipeline. Adapting for these restrictions is implemented > + * via the partition algorithm. > + * > + * The partition windows and sizes are based on the output size of the WPF > + * before rotation, which is represented by the input parameters to the WPF > + * entity in our pipeline. > */ > > /** > -- > 2.19.1 >
Hi Laurent, On 18/04/2019 07:33, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thu, Apr 11, 2019 at 05:12:54PM +0100, Kieran Bingham wrote: >> The image partition algorithm operates on the image dimensions as input >> into the WPF entity. Document this in the code block header. >> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> --- >> drivers/media/platform/vsp1/vsp1_video.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c >> index 563f9a02c373..d1ecc3d91290 100644 >> --- a/drivers/media/platform/vsp1/vsp1_video.c >> +++ b/drivers/media/platform/vsp1/vsp1_video.c >> @@ -173,6 +173,14 @@ static int __vsp1_video_try_format(struct vsp1_video *video, >> >> /* ----------------------------------------------------------------------------- >> * VSP1 Partition Algorithm support >> + * >> + * VSP hardware can have restrictions on image width dependent on the hardware > > Did you mean s/dependent/depending/ ? Yes, it looks like I did. Or otherwise, it could be 'dependant upon the hardware' ... but I'll go with depending. Updated. > >> + * configuration of the pipeline. Adapting for these restrictions is implemented >> + * via the partition algorithm. >> + * >> + * The partition windows and sizes are based on the output size of the WPF >> + * before rotation, which is represented by the input parameters to the WPF >> + * entity in our pipeline. >> */ >> >> /** >> -- >> 2.19.1 >> >
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 563f9a02c373..d1ecc3d91290 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -173,6 +173,14 @@ static int __vsp1_video_try_format(struct vsp1_video *video, /* ----------------------------------------------------------------------------- * VSP1 Partition Algorithm support + * + * VSP hardware can have restrictions on image width dependent on the hardware + * configuration of the pipeline. Adapting for these restrictions is implemented + * via the partition algorithm. + * + * The partition windows and sizes are based on the output size of the WPF + * before rotation, which is represented by the input parameters to the WPF + * entity in our pipeline. */ /**