| Message ID | 20190425183546.16244-3-ezequiel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Assorted CODA fixes | expand |
On Thu, 2019-04-25 at 15:35 -0300, Ezequiel Garcia wrote: > The mutex unlock in the threaded interrupt handler is not paired > with any mutex lock. Remove it. > > This bug has been here for a really long time, so it applies > to any stable repo. > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > --- > drivers/media/platform/coda/coda-bit.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c > index eaa86737fa04..bddd2f5c8c2b 100644 > --- a/drivers/media/platform/coda/coda-bit.c > +++ b/drivers/media/platform/coda/coda-bit.c > @@ -2308,7 +2308,6 @@ irqreturn_t coda_irq_handler(int irq, void *data) > if (ctx == NULL) { > v4l2_err(&dev->v4l2_dev, > "Instance released before the end of transaction\n"); > - mutex_unlock(&dev->coda_mutex); > return IRQ_HANDLED; > } I think this is right. I've never seen this message, and I'm not sure if it is even possible to get a PIC_RUN completion interrupt with the m2m context already released, since we reset the hardware on timeouts in pic_run_work. Either way, the mutex is unlocked in pic_run_work after a timeout if the completion is not triggered, so this one has to go. Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index eaa86737fa04..bddd2f5c8c2b 100644 --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -2308,7 +2308,6 @@ irqreturn_t coda_irq_handler(int irq, void *data) if (ctx == NULL) { v4l2_err(&dev->v4l2_dev, "Instance released before the end of transaction\n"); - mutex_unlock(&dev->coda_mutex); return IRQ_HANDLED; }
The mutex unlock in the threaded interrupt handler is not paired with any mutex lock. Remove it. This bug has been here for a really long time, so it applies to any stable repo. Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- drivers/media/platform/coda/coda-bit.c | 1 - 1 file changed, 1 deletion(-)