diff mbox series

node: Fix warning while make xmldocs

Message ID 20190624035807.20628-1-standby24x7@gmail.com (mailing list archive)
State New, archived
Headers show
Series node: Fix warning while make xmldocs | expand

Commit Message

Masanari Iida June 24, 2019, 3:58 a.m. UTC
This patch fixes following warning while make xmldocs.
./drivers/base/node.c:690: warning: Excess function parameter
 'mem_node' description in 'register_memory_node_under_compute_node'
./drivers/base/node.c:690: warning: Excess function parameter
 'cpu_node' description in 'register_memory_node_under_compute_node'

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 drivers/base/node.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rafael J. Wysocki June 24, 2019, 8:24 a.m. UTC | #1
On Mon, Jun 24, 2019 at 5:58 AM Masanari Iida <standby24x7@gmail.com> wrote:
>
> This patch fixes following warning while make xmldocs.
> ./drivers/base/node.c:690: warning: Excess function parameter
>  'mem_node' description in 'register_memory_node_under_compute_node'
> ./drivers/base/node.c:690: warning: Excess function parameter
>  'cpu_node' description in 'register_memory_node_under_compute_node'
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
>  drivers/base/node.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index d8c02e65df68..944ee45d122f 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -673,8 +673,8 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid)
>  /**
>   * register_memory_node_under_compute_node - link memory node to its compute
>   *                                          node for a given access class.
> - * @mem_node:  Memory node number
> - * @cpu_node:  Cpu  node number
> + * @mem_nid:   Memory node identifier
> + * @cpu_nid:   Cpu  node identifier
>   * @access:    Access class to register
>   *
>   * Description:
> --
> 2.22.0.190.ga6a95cd1b46e
>
Greg KH July 3, 2019, 7:20 p.m. UTC | #2
On Mon, Jun 24, 2019 at 12:58:07PM +0900, Masanari Iida wrote:
> This patch fixes following warning while make xmldocs.
> ./drivers/base/node.c:690: warning: Excess function parameter
>  'mem_node' description in 'register_memory_node_under_compute_node'
> ./drivers/base/node.c:690: warning: Excess function parameter
>  'cpu_node' description in 'register_memory_node_under_compute_node'
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/base/node.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Someone sent this patch before you did, sorry.

greg k-h
diff mbox series

Patch

diff --git a/drivers/base/node.c b/drivers/base/node.c
index d8c02e65df68..944ee45d122f 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -673,8 +673,8 @@  int register_cpu_under_node(unsigned int cpu, unsigned int nid)
 /**
  * register_memory_node_under_compute_node - link memory node to its compute
  *					     node for a given access class.
- * @mem_node:	Memory node number
- * @cpu_node:	Cpu  node number
+ * @mem_nid:	Memory node identifier
+ * @cpu_nid:	Cpu  node identifier
  * @access:	Access class to register
  *
  * Description: