| Message ID | 20190712224700.11285-1-sean@mess.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] media: mtk-cir: only allow protocols that have software decoders | expand |
On Fri, Jul 12, 2019 at 3:47 PM Sean Young <sean@mess.org> wrote: > > RC_PROTO_BIT_ALL includes protocols like unknown and other that do not > have IR decoders by definition. If these protocols are set in the > allowed_protocols, they will show in the protocols sysfs file but cannot > be enabled. > > Signed-off-by: Sean Young <sean@mess.org> Acked-by: Sean Wang <sean.wang@kernel.org> > --- > drivers/media/rc/mtk-cir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/mtk-cir.c b/drivers/media/rc/mtk-cir.c > index 46101efe017b..9dc467ebae24 100644 > --- a/drivers/media/rc/mtk-cir.c > +++ b/drivers/media/rc/mtk-cir.c > @@ -342,7 +342,7 @@ static int mtk_ir_probe(struct platform_device *pdev) > ir->rc->map_name = map_name ?: RC_MAP_EMPTY; > ir->rc->dev.parent = dev; > ir->rc->driver_name = MTK_IR_DEV; > - ir->rc->allowed_protocols = RC_PROTO_BIT_ALL; > + ir->rc->allowed_protocols = RC_PROTO_BIT_ALL_IR_DECODER; > ir->rc->rx_resolution = MTK_IR_SAMPLE; > ir->rc->timeout = MTK_MAX_SAMPLES * (MTK_IR_SAMPLE + 1); > > -- > 2.21.0 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff --git a/drivers/media/rc/mtk-cir.c b/drivers/media/rc/mtk-cir.c index 46101efe017b..9dc467ebae24 100644 --- a/drivers/media/rc/mtk-cir.c +++ b/drivers/media/rc/mtk-cir.c @@ -342,7 +342,7 @@ static int mtk_ir_probe(struct platform_device *pdev) ir->rc->map_name = map_name ?: RC_MAP_EMPTY; ir->rc->dev.parent = dev; ir->rc->driver_name = MTK_IR_DEV; - ir->rc->allowed_protocols = RC_PROTO_BIT_ALL; + ir->rc->allowed_protocols = RC_PROTO_BIT_ALL_IR_DECODER; ir->rc->rx_resolution = MTK_IR_SAMPLE; ir->rc->timeout = MTK_MAX_SAMPLES * (MTK_IR_SAMPLE + 1);
RC_PROTO_BIT_ALL includes protocols like unknown and other that do not have IR decoders by definition. If these protocols are set in the allowed_protocols, they will show in the protocols sysfs file but cannot be enabled. Signed-off-by: Sean Young <sean@mess.org> --- drivers/media/rc/mtk-cir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)