diff mbox series

media: ov5695: enable vsync pin output

Message ID 20191011103902.3145-1-wuxy@bitland.com.cn
State New
Headers show
Series media: ov5695: enable vsync pin output | expand

Commit Message

wuxy@bitland.com.cn Oct. 11, 2019, 10:39 a.m. UTC
From: wuxy <wuxy@bitland.corp-partner.google.com>

For Kukui project, the ov5695 vsync signal needs to
be set to output,from ov5695 datasheet,the related
register control methods as follows:

0x3002 Bit[7] FISIN/VSYNC output enable
0x3010 Bit[7] enable FISIN/VSYNC as GPIO controlled by register
0x3008 Bit[7] register control FISIN/VSYNC output

TEST= boot to shell

Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
---
 drivers/media/i2c/ov5695.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Tomasz Figa Oct. 17, 2019, 10:40 a.m. UTC | #1
Hi Xingyu,

On Fri, Oct 11, 2019 at 7:39 PM <wuxy@bitland.com.cn> wrote:
>
> From: wuxy <wuxy@bitland.corp-partner.google.com>
>

Thanks for the patch! Please see my comments inline.

> For Kukui project, the ov5695 vsync signal needs to
> be set to output,from ov5695 datasheet,the related
> register control methods as follows:
>
> 0x3002 Bit[7] FISIN/VSYNC output enable
> 0x3010 Bit[7] enable FISIN/VSYNC as GPIO controlled by register
> 0x3008 Bit[7] register control FISIN/VSYNC output
>
> TEST= boot to shell
>
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> ---
>  drivers/media/i2c/ov5695.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> index 34b7046d9702..71f0eae6037b 100644
> --- a/drivers/media/i2c/ov5695.c
> +++ b/drivers/media/i2c/ov5695.c
> @@ -300,6 +300,9 @@ static const struct regval ov5695_global_regs[] = {
>   * mipi_datarate per lane 840Mbps
>   */
>  static const struct regval ov5695_2592x1944_regs[] = {
> +       {0x3002, 0x80},

The original value of 0xa1 that was in ov5695_global_regs[], has the
0x80 bit set already.

> +       {0x3008, 0x80},
> +       {0x3010, 0x80},

Doesn't this configure the pin to an always-1 output GPIO? I believe
the correct settings for both bits should be 0 and 0 for the pin to be
driven by the hardware vsync generator.

Best regards,
Tomasz
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
index 34b7046d9702..71f0eae6037b 100644
--- a/drivers/media/i2c/ov5695.c
+++ b/drivers/media/i2c/ov5695.c
@@ -300,6 +300,9 @@  static const struct regval ov5695_global_regs[] = {
  * mipi_datarate per lane 840Mbps
  */
 static const struct regval ov5695_2592x1944_regs[] = {
+	{0x3002, 0x80},
+	{0x3008, 0x80},
+	{0x3010, 0x80},
 	{0x3501, 0x7e},
 	{0x366e, 0x18},
 	{0x3800, 0x00},