| Message ID | 20191201161542.69535-4-dwlsalmeida@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dummy_dvb_fe: Tidy up the dummy frontend | expand |
Hi Daniel, On Sun, Dec 01, 2019 at 01:15:39PM -0300, Daniel W. S. Almeida wrote: > From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com> > > Change foo* bar to foo *bar to avoid ERROR: POINTER_LOCATION in checkpatch.pl > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength) > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength) > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr) > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr) > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_sleep(struct dvb_frontend* fe) > > ERROR: "foo* bar" should be "foo *bar" > +static int dvb_dummy_fe_init(struct dvb_frontend* fe) > > ERROR: "foo* bar" should be "foo *bar" > +static void dvb_dummy_fe_release(struct dvb_frontend* fe) > > ERROR: "foo* bar" should be "foo *bar" > + struct dvb_dummy_fe_state* state = fe->demodulator_priv; > > ERROR: "foo* bar" should be "foo *bar" > +struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void) > > ERROR: "foo* bar" should be "foo *bar" > + struct dvb_dummy_fe_state* state = NULL; > > ERROR: "foo* bar" should be "foo *bar" > + struct dvb_dummy_fe_state* state = NULL; > > ERROR: "foo* bar" should be "foo *bar" > + struct dvb_dummy_fe_state* state = NULL; > > Suggested-by: Shuah Khan <skhan@linuxfoundation.org> > Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com> The comments from Mauro in the previous version of this patch have not been addressed: https://patchwork.linuxtv.org/patch/60048/#114016 Thanks, Sean > --- > drivers/media/dvb-frontends/dvb_dummy_fe.c | 24 +++++++++++----------- > drivers/media/dvb-frontends/dvb_dummy_fe.h | 6 +++--- > 2 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c > index 987c3488fe6c..209e7ac0de33 100644 > --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c > +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c > @@ -31,25 +31,25 @@ static int dvb_dummy_fe_read_status(struct dvb_frontend *fe, > return 0; > } > > -static int dvb_dummy_fe_read_ber(struct dvb_frontend* fe, u32* ber) > +static int dvb_dummy_fe_read_ber(struct dvb_frontend *fe, u32 *ber) > { > *ber = 0; > return 0; > } > > -static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength) > +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend *fe, u16 *strength) > { > *strength = 0; > return 0; > } > > -static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr) > +static int dvb_dummy_fe_read_snr(struct dvb_frontend *fe, u16 *snr) > { > *snr = 0; > return 0; > } > > -static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) > +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend *fe, u32 *ucblocks) > { > *ucblocks = 0; > return 0; > @@ -77,12 +77,12 @@ static int dvb_dummy_fe_set_frontend(struct dvb_frontend *fe) > return 0; > } > > -static int dvb_dummy_fe_sleep(struct dvb_frontend* fe) > +static int dvb_dummy_fe_sleep(struct dvb_frontend *fe) > { > return 0; > } > > -static int dvb_dummy_fe_init(struct dvb_frontend* fe) > +static int dvb_dummy_fe_init(struct dvb_frontend *fe) > { > return 0; > } > @@ -99,17 +99,17 @@ static int dvb_dummy_fe_set_voltage(struct dvb_frontend *fe, > return 0; > } > > -static void dvb_dummy_fe_release(struct dvb_frontend* fe) > +static void dvb_dummy_fe_release(struct dvb_frontend *fe) > { > - struct dvb_dummy_fe_state* state = fe->demodulator_priv; > + struct dvb_dummy_fe_state *state = fe->demodulator_priv; > kfree(state); > } > > static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops; > > -struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void) > +struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) > { > - struct dvb_dummy_fe_state* state = NULL; > + struct dvb_dummy_fe_state *state = NULL; > > /* allocate memory for the internal state */ > state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); > @@ -131,7 +131,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops; > > struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void) > { > - struct dvb_dummy_fe_state* state = NULL; > + struct dvb_dummy_fe_state *state = NULL; > > /* allocate memory for the internal state */ > state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); > @@ -153,7 +153,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops; > > struct dvb_frontend *dvb_dummy_fe_qam_attach(void) > { > - struct dvb_dummy_fe_state* state = NULL; > + struct dvb_dummy_fe_state *state = NULL; > > /* allocate memory for the internal state */ > state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); > diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.h b/drivers/media/dvb-frontends/dvb_dummy_fe.h > index 526fabd7751f..35efe2ce1a88 100644 > --- a/drivers/media/dvb-frontends/dvb_dummy_fe.h > +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.h > @@ -12,9 +12,9 @@ > #include <media/dvb_frontend.h> > > #if IS_REACHABLE(CONFIG_DVB_DUMMY_FE) > -extern struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void); > -extern struct dvb_frontend* dvb_dummy_fe_qpsk_attach(void); > -extern struct dvb_frontend* dvb_dummy_fe_qam_attach(void); > +extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void); > +extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void); > +extern struct dvb_frontend *dvb_dummy_fe_qam_attach(void); > #else > static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) > { > -- > 2.24.0
Hi Sean, thanks for reviewing this! > The comments from Mauro in the previous version of this patch have not been > addressed: > > https://patchwork.linuxtv.org/patch/60048/#114016 > > Thanks, > > Sean As you've also noted, I have these as separate patches, i.e. https://patchwork.linuxtv.org/patch/60430/ https://patchwork.linuxtv.org/patch/60432/ I will squash them with this one and send v2. I will also drop this from the series: https://patchwork.linuxtv.org/patch/60428/ Is this OK with you?
Hi Daniel, On Tue, Dec 31, 2019 at 03:14:04PM -0300, Daniel W. S. Almeida wrote: > Hi Sean, thanks for reviewing this! > > > > The comments from Mauro in the previous version of this patch have not been > > addressed: > > > > https://patchwork.linuxtv.org/patch/60048/#114016 > > > > Thanks, > > > > Sean > > As you've also noted, I have these as separate patches, i.e. > > https://patchwork.linuxtv.org/patch/60430/ > > https://patchwork.linuxtv.org/patch/60432/ > > > I will squash them with this one and send v2. I will also drop this from the > series: > > https://patchwork.linuxtv.org/patch/60428/ > > > Is this OK with you? That's perfect, although v2 already exists so please name it v3 (or whatever the next available version is). Thanks! Sean
diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c index 987c3488fe6c..209e7ac0de33 100644 --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c @@ -31,25 +31,25 @@ static int dvb_dummy_fe_read_status(struct dvb_frontend *fe, return 0; } -static int dvb_dummy_fe_read_ber(struct dvb_frontend* fe, u32* ber) +static int dvb_dummy_fe_read_ber(struct dvb_frontend *fe, u32 *ber) { *ber = 0; return 0; } -static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength) +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend *fe, u16 *strength) { *strength = 0; return 0; } -static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr) +static int dvb_dummy_fe_read_snr(struct dvb_frontend *fe, u16 *snr) { *snr = 0; return 0; } -static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend *fe, u32 *ucblocks) { *ucblocks = 0; return 0; @@ -77,12 +77,12 @@ static int dvb_dummy_fe_set_frontend(struct dvb_frontend *fe) return 0; } -static int dvb_dummy_fe_sleep(struct dvb_frontend* fe) +static int dvb_dummy_fe_sleep(struct dvb_frontend *fe) { return 0; } -static int dvb_dummy_fe_init(struct dvb_frontend* fe) +static int dvb_dummy_fe_init(struct dvb_frontend *fe) { return 0; } @@ -99,17 +99,17 @@ static int dvb_dummy_fe_set_voltage(struct dvb_frontend *fe, return 0; } -static void dvb_dummy_fe_release(struct dvb_frontend* fe) +static void dvb_dummy_fe_release(struct dvb_frontend *fe) { - struct dvb_dummy_fe_state* state = fe->demodulator_priv; + struct dvb_dummy_fe_state *state = fe->demodulator_priv; kfree(state); } static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops; -struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void) +struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) { - struct dvb_dummy_fe_state* state = NULL; + struct dvb_dummy_fe_state *state = NULL; /* allocate memory for the internal state */ state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); @@ -131,7 +131,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops; struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void) { - struct dvb_dummy_fe_state* state = NULL; + struct dvb_dummy_fe_state *state = NULL; /* allocate memory for the internal state */ state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); @@ -153,7 +153,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops; struct dvb_frontend *dvb_dummy_fe_qam_attach(void) { - struct dvb_dummy_fe_state* state = NULL; + struct dvb_dummy_fe_state *state = NULL; /* allocate memory for the internal state */ state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.h b/drivers/media/dvb-frontends/dvb_dummy_fe.h index 526fabd7751f..35efe2ce1a88 100644 --- a/drivers/media/dvb-frontends/dvb_dummy_fe.h +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.h @@ -12,9 +12,9 @@ #include <media/dvb_frontend.h> #if IS_REACHABLE(CONFIG_DVB_DUMMY_FE) -extern struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void); -extern struct dvb_frontend* dvb_dummy_fe_qpsk_attach(void); -extern struct dvb_frontend* dvb_dummy_fe_qam_attach(void); +extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void); +extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void); +extern struct dvb_frontend *dvb_dummy_fe_qam_attach(void); #else static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) {