| Message ID | 20200115191334.27346-1-dafna.hirschfeld@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] media: vimc: streamer: if kthread_stop fails, ignore the error | expand |
diff --git a/drivers/media/platform/vimc/vimc-streamer.c b/drivers/media/platform/vimc/vimc-streamer.c index cd6b55433c9e..417970dbad14 100644 --- a/drivers/media/platform/vimc/vimc-streamer.c +++ b/drivers/media/platform/vimc/vimc-streamer.c @@ -216,7 +216,7 @@ int vimc_streamer_s_stream(struct vimc_stream *stream, ret = kthread_stop(stream->kthread); if (ret) - return ret; + dev_warn(ved->dev, "kthread_stop returned '%d'\n", ret); stream->kthread = NULL;
Ignore errors returned from kthread_stop since the vimc subdevices should still be notified that streaming stopped so they can release the memory for the streaming, and also kthread should be set to NULL. kthread_stop can return -EINTR in case the thread did not yet ran. This can happen if userspace calls streamon and streamoff right after. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- Changes from v1: undo deletion of an empty line drivers/media/platform/vimc/vimc-streamer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)