| Message ID | 20200428170405.GA1649098@kroah.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: media: imx: no need to check return value of debugfs_create functions | expand |
Hi Greg, Thanks for the cleanup. On Tue, Apr 28, 2020 at 07:04:05PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Rui Miguel Silva <rmfrfs@gmail.com> > Cc: Steve Longerbeam <slongerbeam@gmail.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: linux-media@vger.kernel.org > Cc: devel@driverdev.osuosl.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com> Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 29 ++++------------------ > 1 file changed, 5 insertions(+), 24 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index fbc1a924652a..d7c9e7343f1f 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -915,33 +915,14 @@ static int mipi_csis_dump_regs_show(struct seq_file *m, void *private) > } > DEFINE_SHOW_ATTRIBUTE(mipi_csis_dump_regs); > > -static int mipi_csis_debugfs_init(struct csi_state *state) > +static void mipi_csis_debugfs_init(struct csi_state *state) > { > - struct dentry *d; > - > - if (!debugfs_initialized()) > - return -ENODEV; > - > state->debugfs_root = debugfs_create_dir(dev_name(state->dev), NULL); > - if (!state->debugfs_root) > - return -ENOMEM; > - > - d = debugfs_create_bool("debug_enable", 0600, state->debugfs_root, > - &state->debug); > - if (!d) > - goto remove_debugfs; > - > - d = debugfs_create_file("dump_regs", 0600, state->debugfs_root, > - state, &mipi_csis_dump_regs_fops); > - if (!d) > - goto remove_debugfs; > - > - return 0; > - > -remove_debugfs: > - debugfs_remove_recursive(state->debugfs_root); > > - return -ENOMEM; > + debugfs_create_bool("debug_enable", 0600, state->debugfs_root, > + &state->debug); > + debugfs_create_file("dump_regs", 0600, state->debugfs_root, state, > + &mipi_csis_dump_regs_fops); > } > > static void mipi_csis_debugfs_exit(struct csi_state *state) > -- > 2.26.2 >
diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c index fbc1a924652a..d7c9e7343f1f 100644 --- a/drivers/staging/media/imx/imx7-mipi-csis.c +++ b/drivers/staging/media/imx/imx7-mipi-csis.c @@ -915,33 +915,14 @@ static int mipi_csis_dump_regs_show(struct seq_file *m, void *private) } DEFINE_SHOW_ATTRIBUTE(mipi_csis_dump_regs); -static int mipi_csis_debugfs_init(struct csi_state *state) +static void mipi_csis_debugfs_init(struct csi_state *state) { - struct dentry *d; - - if (!debugfs_initialized()) - return -ENODEV; - state->debugfs_root = debugfs_create_dir(dev_name(state->dev), NULL); - if (!state->debugfs_root) - return -ENOMEM; - - d = debugfs_create_bool("debug_enable", 0600, state->debugfs_root, - &state->debug); - if (!d) - goto remove_debugfs; - - d = debugfs_create_file("dump_regs", 0600, state->debugfs_root, - state, &mipi_csis_dump_regs_fops); - if (!d) - goto remove_debugfs; - - return 0; - -remove_debugfs: - debugfs_remove_recursive(state->debugfs_root); - return -ENOMEM; + debugfs_create_bool("debug_enable", 0600, state->debugfs_root, + &state->debug); + debugfs_create_file("dump_regs", 0600, state->debugfs_root, state, + &mipi_csis_dump_regs_fops); } static void mipi_csis_debugfs_exit(struct csi_state *state)
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Rui Miguel Silva <rmfrfs@gmail.com> Cc: Steve Longerbeam <slongerbeam@gmail.com> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: linux-media@vger.kernel.org Cc: devel@driverdev.osuosl.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/staging/media/imx/imx7-mipi-csis.c | 29 ++++------------------ 1 file changed, 5 insertions(+), 24 deletions(-)