From patchwork Tue May 26 22:25:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Karlman X-Patchwork-Id: 11571491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E2A74739 for ; Tue, 26 May 2020 22:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF4A0208E4 for ; Tue, 26 May 2020 22:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="Df8GllVi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390476AbgEZWZQ (ORCPT ); Tue, 26 May 2020 18:25:16 -0400 Received: from o1.b.az.sendgrid.net ([208.117.55.133]:47535 "EHLO o1.b.az.sendgrid.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390051AbgEZWZP (ORCPT ); Tue, 26 May 2020 18:25:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:to:cc:content-type:content-transfer-encoding; s=001; bh=gYebp9rzYUVBATcyaT/NfFRbcFQwq1Ai5f6uhR6SvfA=; b=Df8GllViA4xdGWlSI7AzAilMI50SV8LNsHjpdMBiDjx076/Wb5G8nZ2SjYfPKuQgXPij 0TX+paptKResOztyP7Bb/hnwYBl/7l/Uy4/IsXWWy8wZ6GsyvG2b9rL5FUuyxviLE7kUyS loxU517BiJ/EoXHTQIKqTqmpcBo+SgOxk= Received: by filterdrecv-p3iad2-8ddf98858-4fqk8 with SMTP id filterdrecv-p3iad2-8ddf98858-4fqk8-19-5ECD974A-54 2020-05-26 22:25:15.015279878 +0000 UTC m=+5347060.449712244 Received: from bionic.localdomain (unknown) by ismtpd0007p1lon1.sendgrid.net (SG) with ESMTP id pOuU-hH5TrqIU--iWX2dZg Tue, 26 May 2020 22:25:14.675 +0000 (UTC) From: Jonas Karlman Subject: [PATCH] media: v4l2-ctrls: Unset correct HEVC loop filter flag Date: Tue, 26 May 2020 22:25:15 +0000 (UTC) Message-Id: <20200526222511.19250-1-jonas@kwiboo.se> X-Mailer: git-send-email 2.17.1 X-SG-EID: TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxAfZekEeQsTe+RrMu3cja6a0h4NucujZqb2jdTqObeyTrc/1/gi0sEhPbGFU5ou9bsWpLl0pN10UM/X8siVB8aR03r7zPmISozzjuB+5kGzEgfvfDYHE44zTBSx9Qta2L9/RjT+Sf/ffRhAYyclwBqcLSNSFH/h0F/do6GTK6ktahwoHDOTD3tjay1A4W3KZx4SU2Xu+1Agb8XZRGQ7iYeXr8Q== To: Hans Verkuil , Mauro Carvalho Chehab , Paul Kocialkowski Cc: Ezequiel Garcia , Boris Brezillon , Jernej Skrabec , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Karlman Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Wrong loop filter flag is unset when tiles enabled flag is not set, this cause HEVC decoding issues with Rockchip Video Decoder. Fix this by unsetting the loop filter across tiles enabled flag instead of the pps loop filter across slices enabled flag when tiles are disabled. Fixes: 256fa3920874 ("media: v4l: Add definitions for HEVC stateless decoding") Signed-off-by: Jonas Karlman --- drivers/media/v4l2-core/v4l2-ctrls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index b2e5804f1aa9..ebd7054d18ac 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -2081,7 +2081,7 @@ static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx, sizeof(p_hevc_pps->row_height_minus1)); p_hevc_pps->flags &= - ~V4L2_HEVC_PPS_FLAG_PPS_LOOP_FILTER_ACROSS_SLICES_ENABLED; + ~V4L2_HEVC_PPS_FLAG_LOOP_FILTER_ACROSS_TILES_ENABLED; } if (p_hevc_pps->flags &