| Message ID | 20200622234740.72825-2-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Small fixes around cacheflush.h | expand |
Hi Nathan, Thank you for the patch. On Mon, Jun 22, 2020 at 04:47:39PM -0700, Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > As Geert and Laurent point out, this driver does not need this header in > the two files that include it. Remove it so there are no warnings. > > Fixes: e0cf615d725c ("asm-generic: don't include <linux/mm.h> in cacheflush.h") > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/omap3isp/isp.c | 2 -- > drivers/media/platform/omap3isp/ispvideo.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..b91e472ee764 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy <t-laramy@ti.com> > */ > > -#include <asm/cacheflush.h> > - > #include <linux/clk.h> > #include <linux/clkdev.h> > #include <linux/delay.h> > diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c > index 10c214bd0903..1ac9aef70dff 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -18,7 +18,6 @@ > #include <linux/sched.h> > #include <linux/slab.h> > #include <linux/vmalloc.h> > -#include <asm/cacheflush.h> > > #include <media/v4l2-dev.h> > #include <media/v4l2-ioctl.h> > > base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Em Mon, 22 Jun 2020 16:47:39 -0700 Nathan Chancellor <natechancellor@gmail.com> escreveu: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > As Geert and Laurent point out, this driver does not need this header in > the two files that include it. Remove it so there are no warnings. > > Fixes: e0cf615d725c ("asm-generic: don't include <linux/mm.h> in cacheflush.h") > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/media/platform/omap3isp/isp.c | 2 -- > drivers/media/platform/omap3isp/ispvideo.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..b91e472ee764 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy <t-laramy@ti.com> > */ > > -#include <asm/cacheflush.h> > - > #include <linux/clk.h> > #include <linux/clkdev.h> > #include <linux/delay.h> > diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c > index 10c214bd0903..1ac9aef70dff 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -18,7 +18,6 @@ > #include <linux/sched.h> > #include <linux/slab.h> > #include <linux/vmalloc.h> > -#include <asm/cacheflush.h> > > #include <media/v4l2-dev.h> > #include <media/v4l2-ioctl.h> > > base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821 Thanks, Mauro
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index a4ee6b86663e..b91e472ee764 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -39,8 +39,6 @@ * Troy Laramy <t-laramy@ti.com> */ -#include <asm/cacheflush.h> - #include <linux/clk.h> #include <linux/clkdev.h> #include <linux/delay.h> diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index 10c214bd0903..1ac9aef70dff 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -18,7 +18,6 @@ #include <linux/sched.h> #include <linux/slab.h> #include <linux/vmalloc.h> -#include <asm/cacheflush.h> #include <media/v4l2-dev.h> #include <media/v4l2-ioctl.h>
After mm.h was removed from the asm-generic version of cacheflush.h, s390 allyesconfig shows several warnings of the following nature: In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, from drivers/media/platform/omap3isp/isp.c:42: ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' declared inside parameter list will not be visible outside of this definition or declaration As Geert and Laurent point out, this driver does not need this header in the two files that include it. Remove it so there are no warnings. Fixes: e0cf615d725c ("asm-generic: don't include <linux/mm.h> in cacheflush.h") Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/media/platform/omap3isp/isp.c | 2 -- drivers/media/platform/omap3isp/ispvideo.c | 1 - 2 files changed, 3 deletions(-) base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821