From patchwork Wed Jul 1 16:48:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baidyanath Kundu X-Patchwork-Id: 11636901 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2A06B618 for ; Wed, 1 Jul 2020 16:49:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D32E2067D for ; Wed, 1 Jul 2020 16:49:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uS1ngtV0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732475AbgGAQt3 (ORCPT ); Wed, 1 Jul 2020 12:49:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732161AbgGAQt2 (ORCPT ); Wed, 1 Jul 2020 12:49:28 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 274EFC08C5C1; Wed, 1 Jul 2020 09:49:28 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id o1so3562325plk.1; Wed, 01 Jul 2020 09:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vI6gy/BQmKGVnvRCjRKUqB8Aaf0/siwXKBwcZ/RvlFQ=; b=uS1ngtV06+ibIy7BC1VMuDObb8Q0N4F2ySdBjn3Mu+7bJ+zcpJeKMR09ud4BYh8ykY PtGzsHCiaIP/Cqp6eWWa5gYvvDWnLjSxcSmQHWcl2dkvqfgv0T+qzRGdLNhkaLVtJqp9 azk+HwmF7ANYINDYc+qxB/kHzb153vYFoWEpElK5ehF5bnzcutvUVWJ+1k5Syk6SbQm8 lMWIRIlJxEPnQQQSIJWkz6K6fufneh9WQkIRayP7T740WHYhpJXQWgHhzR5V/GCebwlo AhUeJjt4je6Pa9WhHN/JiIVZYXIMiR5D2xXULVfSlaij56tPDfXTqMXLr28ZWClU2L3M AcAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vI6gy/BQmKGVnvRCjRKUqB8Aaf0/siwXKBwcZ/RvlFQ=; b=OmWOXA4tNIZblC29V1PG8P3AD3KBcL3lnJNXw2sesQAEzwc0jvw+cJKxWBFmp+ge3D /3ooj6Acu66fGVnDLQ5sZ4KEc03klq/AGnqOAHAvRm+/YqHTx/7LlnDUtepqQKWEOHox +wb+u09M01SmYveIKxtYbCIyQn5Il4NoEwrViwRYfgYhc0JjqkWN/E/YG6M2Oi53Yr5S wagpSuQ91e60KPRXcoIDjpJM3E4SWaTwOQt6/M+p+e5SDiQ3c3dzblp/TUchYrR1F0l7 g9EneRQZ8LuNNstwnDZYLHqW1W3Zx0APKvuMA6I1xc7pojruP9/46tOu5A/ClMvO4VSu H5sQ== X-Gm-Message-State: AOAM533F750vMYwPrAonIAFMsOC0aayC43wcr/H0SE0vZULf5fCg7S0O szMZJ773msTfjQv8Y3C7oD8= X-Google-Smtp-Source: ABdhPJzSpu8yGeFP+GzyEybUVtNPrGp7KzIjkWRSocFZg5FH1LYFxmnwcmssvlHFkT2CAJLDzffvAg== X-Received: by 2002:a17:90a:d30c:: with SMTP id p12mr7873993pju.4.1593622167420; Wed, 01 Jul 2020 09:49:27 -0700 (PDT) Received: from localhost.localdomain ([103.88.59.57]) by smtp.googlemail.com with ESMTPSA id s9sm6470611pjz.2.2020.07.01.09.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 09:49:26 -0700 (PDT) From: Baidyanath Kundu To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, Baidyanath Kundu Subject: [PATCH] Staging: atomisp: Fix __func__ style warnings Date: Wed, 1 Jul 2020 22:18:42 +0530 Message-Id: <20200701164842.1325-1-kundubaidya99@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch fixes the checkpatch.pl warning: Prefer using '"%s...", __func__' to using '', this function's name, in a string Signed-off-by: Baidyanath Kundu --- .../atomisp/pci/base/refcount/src/refcount.c | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c index cf02737cf8d4..a9c881631f4a 100644 --- a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c +++ b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c @@ -48,7 +48,7 @@ static struct ia_css_refcount_entry *refcount_find_entry(ia_css_ptr ptr, return NULL; if (!myrefcount.items) { ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, - "refcount_find_entry(): Ref count not initialized!\n"); + "%s(): Ref count not initialized!\n", __func__); return NULL; } @@ -73,12 +73,12 @@ int ia_css_refcount_init(uint32_t size) if (size == 0) { ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_init(): Size of 0 for Ref count init!\n"); + "%s(): Size of 0 for Ref count init!\n", __func__); return -EINVAL; } if (myrefcount.items) { ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_init(): Ref count is already initialized\n"); + "%s(): Ref count is already initialized\n", __func__); return -EINVAL; } myrefcount.items = @@ -99,7 +99,7 @@ void ia_css_refcount_uninit(void) u32 i; ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_uninit() entry\n"); + "%s() entry\n", __func__); for (i = 0; i < myrefcount.size; i++) { /* driver verifier tool has issues with &arr[i] and prefers arr + i; as these are actually equivalent @@ -120,7 +120,7 @@ void ia_css_refcount_uninit(void) myrefcount.items = NULL; myrefcount.size = 0; ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_uninit() leave\n"); + "%s() leave\n", __func__); } ia_css_ptr ia_css_refcount_increment(s32 id, ia_css_ptr ptr) @@ -133,7 +133,7 @@ ia_css_ptr ia_css_refcount_increment(s32 id, ia_css_ptr ptr) entry = refcount_find_entry(ptr, false); ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_increment(%x) 0x%x\n", id, ptr); + "%s(%x) 0x%x\n", __func__, id, ptr); if (!entry) { entry = refcount_find_entry(ptr, true); @@ -145,7 +145,7 @@ ia_css_ptr ia_css_refcount_increment(s32 id, ia_css_ptr ptr) if (entry->id != id) { ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, - "ia_css_refcount_increment(): Ref count IDS do not match!\n"); + "%s(): Ref count IDS do not match!\n", __func__); return mmgr_NULL; } @@ -165,7 +165,7 @@ bool ia_css_refcount_decrement(s32 id, ia_css_ptr ptr) struct ia_css_refcount_entry *entry; ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_decrement(%x) 0x%x\n", id, ptr); + "%s(%x) 0x%x\n", __func__, id, ptr); if (ptr == mmgr_NULL) return false; @@ -175,7 +175,7 @@ bool ia_css_refcount_decrement(s32 id, ia_css_ptr ptr) if (entry) { if (entry->id != id) { ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, - "ia_css_refcount_decrement(): Ref count IDS do not match!\n"); + "%s(): Ref count IDS do not match!\n", __func__); return false; } if (entry->count > 0) { @@ -225,8 +225,8 @@ void ia_css_refcount_clear(s32 id, clear_func clear_func_ptr) u32 count = 0; assert(clear_func_ptr); - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "ia_css_refcount_clear(%x)\n", - id); + ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "%s(%x)\n", + __func__, id); for (i = 0; i < myrefcount.size; i++) { /* driver verifier tool has issues with &arr[i] @@ -236,14 +236,14 @@ void ia_css_refcount_clear(s32 id, clear_func clear_func_ptr) entry = myrefcount.items + i; if ((entry->data != mmgr_NULL) && (entry->id == id)) { ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_clear: %x: 0x%x\n", + "%s: %x: 0x%x\n", __func__, id, entry->data); if (clear_func_ptr) { /* clear using provided function */ clear_func_ptr(entry->data); } else { ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_clear: using hmm_free: no clear_func\n"); + "%s: using hmm_free: no clear_func\n", __func__); hmm_free(entry->data); } @@ -260,7 +260,7 @@ void ia_css_refcount_clear(s32 id, clear_func clear_func_ptr) } } ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, - "ia_css_refcount_clear(%x): cleared %d\n", id, + "%s(%x): cleared %d\n", __func__, id, count); }