| Message ID | 20200719112133.58236-1-grandmaster@al2klimov.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [for,v5.9] media: omap: Replace HTTP links with HTTPS ones | expand |
Hi Alexander, Thank you for the patch. On Sun, Jul 19, 2020 at 01:21:33PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > If both the HTTP and HTTPS versions > return 200 OK and serve the same content: > Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I expect Sakari to take this patch in his tree when he will be back from vacation at the end of the month. > --- > Continuing my work started at 93431e0607e5. > See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master > (Actually letting a shell for loop submit all this stuff for me.) > > If there are any URLs to be removed completely > or at least not (just) HTTPSified: > Just clearly say so and I'll *undo my change*. > See also: https://lkml.org/lkml/2020/6/27/64 > > If there are any valid, but yet not changed URLs: > See: https://lkml.org/lkml/2020/6/26/837 > > If you apply the patch, please let me know. > > Sorry again to all maintainers who complained about subject lines. > Now I realized that you want an actually perfect prefixes, > not just subsystem ones. > I tried my best... > And yes, *I could* (at least half-)automate it. > Impossible is nothing! :) > > > drivers/media/platform/omap3isp/isp.c | 2 +- > drivers/staging/media/omap4iss/iss.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index b91e472ee764..74fa67082e09 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -142,7 +142,7 @@ static struct isp_reg isp_reg_list[] = { > * readback the same register, in this case the revision register. > * > * See this link for reference: > - * http://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html > + * https://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html > */ > void omap3isp_flush(struct isp_device *isp) > { > diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c > index 6fb60b58447a..e06ea7ea1e50 100644 > --- a/drivers/staging/media/omap4iss/iss.c > +++ b/drivers/staging/media/omap4iss/iss.c > @@ -55,7 +55,7 @@ static void iss_print_status(struct iss_device *iss) > * readback the same register, in this case the revision register. > * > * See this link for reference: > - * http://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html > + * https://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html > */ > static void omap4iss_flush(struct iss_device *iss) > {
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index b91e472ee764..74fa67082e09 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -142,7 +142,7 @@ static struct isp_reg isp_reg_list[] = { * readback the same register, in this case the revision register. * * See this link for reference: - * http://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html + * https://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html */ void omap3isp_flush(struct isp_device *isp) { diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index 6fb60b58447a..e06ea7ea1e50 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -55,7 +55,7 @@ static void iss_print_status(struct iss_device *iss) * readback the same register, in this case the revision register. * * See this link for reference: - * http://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html + * https://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html */ static void omap4iss_flush(struct iss_device *iss) {
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master (Actually letting a shell for loop submit all this stuff for me.) If there are any URLs to be removed completely or at least not (just) HTTPSified: Just clearly say so and I'll *undo my change*. See also: https://lkml.org/lkml/2020/6/27/64 If there are any valid, but yet not changed URLs: See: https://lkml.org/lkml/2020/6/26/837 If you apply the patch, please let me know. Sorry again to all maintainers who complained about subject lines. Now I realized that you want an actually perfect prefixes, not just subsystem ones. I tried my best... And yes, *I could* (at least half-)automate it. Impossible is nothing! :) drivers/media/platform/omap3isp/isp.c | 2 +- drivers/staging/media/omap4iss/iss.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)