| Message ID | 20200723132014.4597-4-dafna.hirschfeld@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: staging: rkisp1: add support to V4L2_CAP_IO_MC | expand |
Hi Dafna, On 7/23/20 10:20 AM, Dafna Hirschfeld wrote: > It is not clear if the device is able to support format > V4L2_PIX_FMT_YUV444M, and also this is not an important format > so remove it. I would just improve this a bit, how did you reach this conclusion, what is not clear, tests you made, etc. I know this was discussed a in previous thread, but it would be nice to add the info here. Regards, Helen > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > --- > drivers/staging/media/rkisp1/rkisp1-capture.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c > index 470e49d5d889..fd0864194203 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-capture.c > +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c > @@ -131,12 +131,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = { > .uv_swap = 1, > .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, > }, > - /* yuv444 */ > - { > - .fourcc = V4L2_PIX_FMT_YUV444M, > - .uv_swap = 0, > - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, > - }, > /* yuv400 */ > { > .fourcc = V4L2_PIX_FMT_GREY, > @@ -243,13 +237,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { > .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, > .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV420, > }, > - /* yuv444 */ > - { > - .fourcc = V4L2_PIX_FMT_YUV444M, > - .uv_swap = 0, > - .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, > - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV444, > - }, > /* yuv400 */ > { > .fourcc = V4L2_PIX_FMT_GREY, >
diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c index 470e49d5d889..fd0864194203 100644 --- a/drivers/staging/media/rkisp1/rkisp1-capture.c +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c @@ -131,12 +131,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = { .uv_swap = 1, .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, }, - /* yuv444 */ - { - .fourcc = V4L2_PIX_FMT_YUV444M, - .uv_swap = 0, - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, - }, /* yuv400 */ { .fourcc = V4L2_PIX_FMT_GREY, @@ -243,13 +237,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV420, }, - /* yuv444 */ - { - .fourcc = V4L2_PIX_FMT_YUV444M, - .uv_swap = 0, - .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV444, - }, /* yuv400 */ { .fourcc = V4L2_PIX_FMT_GREY,
It is not clear if the device is able to support format V4L2_PIX_FMT_YUV444M, and also this is not an important format so remove it. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- drivers/staging/media/rkisp1/rkisp1-capture.c | 13 ------------- 1 file changed, 13 deletions(-)